946585 - Change how the form element pointer affects parsing template elements, to reduce weirdness in templates

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Ryosuke Niwa]

Make HTML5 parser changes to match the HTML5 specification change: http://html5.org/tools/web-apps-tracker?from=8330&to=8331

Change how the form element pointer affects parsing <template> elements, to reduce weirdness in templates (e.g. before you couldn't have a template that contained a form if it was itself inside a form).

Also see https://bugs.webkit.org/show_bug.cgi?id=125279

Comment 1

[Ryosuke Niwa]

WebKit merged this change in http://trac.webkit.org/changeset/160182.

Comment 2

[William Chen [:wchen]]

Attachment: update implementation to match latest spec changes

Links to parts of the spec that changes:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-inbody
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-intable
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#parsing-html-fragments

The "Parsing HTML fragments" change has a mistake, I've filed a spec bug for it (https://www.w3.org/Bugs/Public/show_bug.cgi?id=24017)

Comment 3

[William Chen [:wchen]]

I'll attach my tests when I feel I have sufficient coverage for the changes.

Comment 4

[Henri Sivonen (:hsivonen)]

Comment on attachment 8343554 [details] [diff] [review]
update implementation to match latest spec changes

>+nsIContent**
>+nsHtml5TreeBuilder::getFormPointerForContext(nsIContent** aContext)
>+{

r+ provided that you add an assertion here to check that we are on the main thread when getFormPointerForContext runs.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Do you know if there's a test in web-platform-tests? If not, can you please write one?

Comment 6

[William Chen [:wchen]]

Spec was updated to remove special casing of template elements when trying to find the form pointer for a context element. (https://www.w3.org/Bugs/Public/show_bug.cgi?id=24017#c4).

(In reply to :Ms2ger from comment #5)
> Do you know if there's a test in web-platform-tests? If not, can you please
> write one?

I don't see any. Almost all of the changes here are better covered with parser tests, but I'll add a test to web-platform-tests for making sure that we have the correct form pointer when parsing fragments.

Comment 7

[William Chen [:wchen]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7b0c3b046b2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7b0c3b046b2