946594 - (e10s-FVD) Flash Video Downloader - YouTube HD Download [4K] e10s compat bug

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

This bug only affects e10s. Flash Video Downloader can successfully download Vimeo Flash videos when e10s is disabled.

STR:
1. Install Flash Video Downloader: https://addons.mozilla.org/en-US/firefox/addon/flash-video-downloader/
2. Play a YouTube Flash video
3. Click Flash Video Downloader's blue arrow icon to download the YouTube Flash video
4. It works!
5. Play a Vimeo Flash video

RESULT:
Flash Video Downloader's arrow icon does not turn blue because it can't find the Vimeo Flash video.

Comment 1

[Chris Peterson [:cpeterson]]

See also Video DownloadHelper addon bug 930788.

Comment 2

[Chris Peterson [:cpeterson]]

I can reproduce this bug with Beta 31, but I can't test Aurora 32 or Nightly 33 because Vimeo is only serving HTML5 video to those channels: bug 1040972.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Given bug 1040972 was resolved invalid, and the Vimeo-side change means that this Vimeo-specific bug doesn't reproduce anymore, should this bug be closed too?

Comment 4

[Chris Peterson [:cpeterson]]

If Vimeo no longer serves Flash videos, Flash Video Downloader might still be broken on other sites. We should probably test one or more of the add-on's other supported sites: YouTube, Google Video (video.google.com), DailyMotion (dailymotion.com), Metacafe (metacafe.com), Break.com (break.com), Blip.tv (blip.tv), MyVideo.de (myvideo.de).

Comment 5

[Chris Peterson [:cpeterson]]

Flash Video Downloader is AMO's seventh most popular add-on.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been contacted through AMO.

Comment 7

[Pavel Scherbakov]

Hi, we will check it out soon.

Thanks.

Comment 8

[Pavel Scherbakov]

We started to work on support e10s, not sure how long it will take considering that review process sometimes takes forever.

BTW, I just uploaded new update of FlashVideDownloader. We added support of 4K Download. Please review.

Comment 9

[Jorge Villalobos [:jorgev] (he/him)]

If you mention on this bug that you have an e10s compatibility update in the queue, we will give it priority.

Comment 10

[Pavel Scherbakov]

Hi,

Just uploaded new version. Everything should work fine. We also fixed Mac compatibility. 

Thanks

Comment 11

[Chris Peterson [:cpeterson]]

Thanks, Pavel! I just tested Flash Video Downloader version 6.9.2 with e10s on my Mac and it worked for me. :)

Comment 12

[Pavel Scherbakov]

You are welcome Chris. 

Let me know if you find anything else. 
If you have any other suggestions, please contact us. There is email on addon's page.

Comment 13

[Pavel Scherbakov]

Hi, 
please take a look on this problem with es10.

https://bugzilla.mozilla.org/show_bug.cgi?id=1110123#c8

Comment 14

[Pavel Scherbakov]

I recently uploaded new version for FVD Downloader
https://addons.mozilla.org/En-us/firefox/addon/flash-video-downloader/

and than I noticed that extension is inactive for all platforms!
Screenshot:
https://nimbus.everhelper.me/client/notes/share/154113/yAXxo6fEI24B3eewLJ37Ws5l1RuAEl3u/

Here is screenshot how it shows after upload
http://nimb.ws/IGZOpP

and this is how it usually it looks:
https://nimbus.everhelper.me/client/notes/share/154115/ThaO5yCpTsKl9WNTKincUx0Fshrucu5t/

and one more screenshot
https://nimbus.everhelper.me/client/notes/share/154116/TgCunKchPcXh7gsg7VP0mBONweG5EANq/

As you see some files are missing.  I deleted that version and current build rolled back to previous working one v6.9.3. Than I downloaded Working one and Uploaded it again with higher version number.
As the result I got the same problem. It means that something wrong on you side. Please help, right now we ant upload updates and current build is pretty old - Jan 3, 2015.

Here is video how I upload build
https://nimbus.everhelper.me/client/notes/share/154577/7EbpHJ92UeJfQv4U1Wy7ZDBSDgz2XEmA/

Thanks.

Comment 15

[Chris Peterson [:cpeterson]]

Jorge: can you please take a look at FVD Downloader in AMO?

The "Add to Firefox" button looks OK/green for me on OS X.

Comment 16

[Pavel Scherbakov]

>>The "Add to Firefox" button looks OK/green for me on OS X.

This is because I had to disable that version and rollback old build. Moreover, we gain has the same problem because current build is old: https://bugzilla.mozilla.org/show_bug.cgi?id=946594

Comment 17

[Pavel Scherbakov]

Update:

I just uploaded new version. Please review it. It looks like the problem is in "ALL Platforms" checkbox.
I unchecked it and check all platforms SEPARATELY and it went through fine. But as far I as know it makes your review process more complicated.

Comment 18

[Jorge Villalobos [:jorgev] (he/him)]

The new version has been approved. We recently made some changes in the Platform selection UI that made things confusing when uploading new versions. It should be fixed on next week's push.

Comment 19

[Pavel Scherbakov]

thanks!

Comment 21

[Jim Mathies [:jimm]]

Assignee: Jim Mathies
Link to add-on:
https://addons.mozilla.org/en-US/firefox/addon/flash-video-downloader/
http://www.flashvideodownloader.org/
Contact info for add-on: AMO
Add-on ID: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}

How well does it work?: 50/50%

Steps to reproduce working features:
- downloading videos works
- settings dialog works
- advertising links in drop down menu seems to work

Issues:
- minor glitches in ux, context menu failed to hide on youtube page
- sometimes the download button doesn't show up
- console spew:
 main_btn is null fvd_single.js:2269:0
 TypeError: main_btn is null
 unsage CPOW usage

Any obvious performance problems?
- Seems to slow down editor functionality
- from about:performance:
 Impact on framerate: 4/10.
 CPU usage: 2%.
 System usage: 0%.
 Blocking process calls: 2%.
 Measure start: 124 seconds ago.
 Process: 6688 (parent).

Chromium version: couldn't find it

Comment 22

[Jim Mathies [:jimm]]

type: xul

Comment 23

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 28.0a1 (Build ID: 20131204030203) on 
windows 8.1 64-bit with the instructions from comment 0 .

Verified as fixed with Firefox Nightly 44.0a1(Build ID:20151011030229)

Mozilla/5.0 (Windows NT 6.3; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0

Comment 24

[:shell escalante]

reopening based on Jim Mathies comment 21 

Hi Jim, How did you get the information under "Any obvious performance problems?"

I'm curious if it is something we can add to our testing requests for teams as they retest updates to see if working?  

It's at version 11 and it passed a soft vision test - but not sure if we're looking at everything we need to.

Comment 25

[Jim Mathies [:jimm]]

(In reply to :shell escalante from comment #24)
> reopening based on Jim Mathies comment 21 
> 
> Hi Jim, How did you get the information under "Any obvious performance
> problems?"
> 
> I'm curious if it is something we can add to our testing requests for teams
> as they retest updates to see if working?  
> 
> It's at version 11 and it passed a soft vision test - but not sure if we're
> looking at everything we need to.

Manual testing and checking about:performance for issues. I did this for all the initial addon testing we did in 2015.

Comment 26

[Andy McKay]

Given the move to WebExtensions, not expecting any more action on this bug, so closing.