946618 - Land some native tests for cubeb

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Paul Adenot (:padenot)]

Now that mozWriteAudio and friends are mostly gone, we don't have any tests to check if cubeb is working properly (as playing a video will fallback on system clock if the stream init fails, and automation does not report the sound output by the speakers).

Cubeb has some tests in its repo, it would be useful to have them running in tbpl.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Add native tests for cubeb. r=

So, I finally got around to doing this. This basically takes the tests that are
in the github repo, and hook them to the test infrastructure.

The cppunittest framework apparently only works with cpp files, so I made
minimal changes to the tests themselves, and renamed them to *.cpp instead of
*.c.

The tests can be run by doing:

> ./mach cppunittest

or

> ./mach cppunittest obj-x86_64-unknown-linux-gnu/media/libcubeb/tests/test_sanity

to run only one, for example.

I think they should show up on tbpl, but I haven't tried yet.

Not requesting review yet because I haven't tested all platforms yet (only
Linux), and I want to add more tests.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Add native tests for cubeb. r=

Comment 3

[Paul Adenot (:padenot)]

Attachment: Update cubeb to pick up new tests. r=

This is just the cubeb update.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Update cubeb to pick up new tests. r=

And now without forgetting to `hg add`.

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8383050 [details] [diff] [review]
Update cubeb to pick up new tests. r=

update.sh needs to be updated to pick up the new files.

Comment 6

[Matthew Gregan [:kinetik]]

Comment on attachment 8383043 [details] [diff] [review]
Add native tests for cubeb. r=

Oh, you updated update.sh here.  Cool.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8383043 [details] [diff] [review]
Add native tests for cubeb. r=

Review of attachment 8383043 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/libcubeb/tests/Makefile.in
@@ +5,5 @@
> +
> +ifeq ($(OS_ARCH),WINNT)
> +  # On windows, the WASAPI backend needs the resampler we have in
> +  # /media/libspeex_resampler, so we can't get away with just linking cubeb's .o
> +  LIBS = $(DEPTH)/layout/media/$(LIB_PREFIX)gkmedias.$(LIB_SUFFIX) \

Please use EXPAND_LIBNAME_PATH

@@ +10,5 @@
> +         $(NULL)
> +else
> +  # Otherwise, we can just grab all the compiled .o and compile against that,
> +  # linking the appriopriate libraries.
> +  LIBS = ../src/*.o

Not great. Especially in the light of changes to come. Try adding a LIBRARY_NAME to media/cubeb/src/moz.build, and link against that lib.

Comment 8

[Paul Adenot (:padenot)]

Attachment: Add native tests for cubeb. r=

This seems to work, and is indeed nicer.

Comment 9

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa5e92d8eb82
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd53f54dbaa9

Comment 10

[Ed Morley [:emorley]]

Backed out for frequent test failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=35590054&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35592438&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35595058&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35594764&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35596524&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35598486&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35598199&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/1bcb0315bc53
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/efdce4998518

Please push to try (or test locally if you can repro locally) before re-landing and ensure the failure rate is <5% :-)

Comment 12

[Paul Adenot (:padenot)]

Hrm, try does not run cppunit on Android, and of course there are problems.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

FYI, a Windows failure too:
https://tbpl.mozilla.org/php/getParsedLog.php?id=35604284&tree=Mozilla-Inbound

Comment 14

[Paul Adenot (:padenot)]

Attachment: Skip some cubeb tests on some platforms. r=

This disable some tests, for example, it makes the test skip floating point
tests on platform that don't support floating point audio, and skip timing test
on platform where we don't honor latency request.

Comment 15

[Paul Adenot (:padenot)]

Attachment: Disable some cubeb tests on Android. r=

This sometime segfault when trying to get the engine, and I rather land this
than let it sit in my queue for too long.

We still have some kind of smoke test in test_audio.c, so that's kind of okay.

Comment 16

[Paul Adenot (:padenot)]

Attachment: Disable part of a cubeb test on Windows 7. r=

This is green all the time with this change, and break 20% of the time without.
This looks like a regression in WASAPI introduced in 7, fixed in 8.

Comment 17

[Paul Adenot (:padenot)]

With all those patches applied, try looks good.

Comment 18

[Paul Adenot (:padenot)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/109ba6e08a76
https://hg.mozilla.org/integration/mozilla-inbound/rev/758934b7d585
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa0b31ea0ab
https://hg.mozilla.org/integration/mozilla-inbound/rev/b199abcbfae1
https://hg.mozilla.org/integration/mozilla-inbound/rev/9fedde6e6e5f

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/109ba6e08a76
https://hg.mozilla.org/mozilla-central/rev/758934b7d585
https://hg.mozilla.org/mozilla-central/rev/3aa0b31ea0ab
https://hg.mozilla.org/mozilla-central/rev/b199abcbfae1
https://hg.mozilla.org/mozilla-central/rev/9fedde6e6e5f