94662 - IMAP: Undo/Redo does not work for imap::delete model

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Navin Gupta]

I found out that we are marking imap delete twice once before we go to the 
server and once after, so it unsets during the deletion, and when we do undo it 
sets back the delete flag. so we will have to decide which one we do not need

Comment 1

[Navin Gupta]

Attachment: proposed fix.

Comment 2

[Navin Gupta]

This case statement was responsible for setting the delete flag back on undo. 
There is no need to send delete/move notification to front-end because we
do not select any message on undo/redo. 
Also for undo/redo where delete model is not moving to trash the dstFolder will 
be null. david, please review. 

Comment 3

[Navin Gupta]

changing summary

Comment 4

[David :Bienvenu]

the code you removed did much more than just send a notification to the front
end - it updated the database as well. Are you sure that's not needed either? I
think it also made it so that when you delete a message in the imap delete
model, the next message gets selected. Does that still work after your change?

Comment 5

[David :Bienvenu]

OK, I take that last part back, since we shouldn't be trying to change the
selection on removing the deleted flag. But we want to reflect the change to the db.

Comment 6

[Navin Gupta]

Attachment: fix

Comment 7

[Navin Gupta]

I have checked deleting all msgs and undo delete still works. This will 
prevent from setting the delete flag again when we are trying to subtract
it. 

Comment 8

[David :Bienvenu]

great, r=bienvenu

Comment 9

[Karen Huang]

Isn't this bug dup of bug 59694?

Comment 10

[Navin Gupta]

Karen, Well not really, it does not toggle

Comment 11

[Navin Gupta]

But the undo/redo part is fixed, may be you can change the summary on that
bug to make it toggle (only). 

Comment 12

[Scott MacGregor]

sr=mscott

Comment 13

[Navin Gupta]

fix checked in. 

Comment 14

[Karen Huang]

Verified on WinNT 08-15-06-trunk build.
Great! Now, Undo/Redo is working on IMAP Mark as deleted mode!

Comment 15

[Karen Huang]

And, I already updated bug 59694 for toggle only.