946645 - Replace all users of CrashReports.jsm with Services.crashes and delete CrashReports.jsm

Status: NEW

(Toolkit :: Crash Reporting, defect, P3)

Description

[Gregory Szorc [:gps]]

CrashReports.jsm is old and janky (literally - it uses synchronous I/O). Users of CrashReports.jsm should be refactored to use Services.crashes from bug 875562 and CrashReports.jsm should be deleted once no in-tree consumers remain.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Use Crashes service in about:crashes

I started down this road for a few minutes as part of working on the
blocking bug. But this work is not blocking getting that bug landed, so
I quickly abandoned it.

about:crashes could use a lot of love. For one, the page title says
"submitted crash reports" even though it mixes pending and submitted. We
should throw a few section headers in there to differentiate between
submitted and pending. I started this work but stopped short because it
wasn't critical to the other bug.

We'll also need a delete API on Services.crashes. I'll add that in the
blocking bug - it's trivial enough to implement.

Comment 2

[(not currently active) Ted Mielczarek]

The "pending crashes are hard to distinguish" thing is bug 512479.

Comment 3

[Gregory Szorc [:gps]]

The requisite parts of bug 875562 have landed and this bug should be unblocked from implementation.

I'm putting this in the mentored bugs pool if anyone wants to have a go at it. There's no docs on MDN yet. You'll be using the new code at https://hg.mozilla.org/mozilla-central/file/default/toolkit/components/crashes/CrashManager.jsm to read crash data. See the existing patch (which no longer works) for inspiration.

Comment 4

[Nachiketh]

Can I take up this bug? I have mozilla-central downloaded, I am new and interested to work on it.

Comment 5

[Gregory Szorc [:gps]]

Yes, you can have it.

I'm on a business trip to Europe until September 2. If you need more information, I encourage you to ping bsmedberg, as I may not respond to bug updates promptly.

Comment 6

[Andrew McCreight [:mccr8]]

Looks like there are still 2 users of CrashReports.jsm.