Closed Bug 946687 Opened 6 years ago Closed 6 years ago

Refactor the ICU detection rules from configure.in and js/src/configure.in into build/autoconf/icu.m4

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is a follow-up to bug 915735 to move the rest of that code into icu.m4.
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Blocks: jsmerge
Comment on attachment 8370596 [details] [diff] [review]
Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

Review of attachment 8370596 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me on the assumption you just moved a lot of code around.
Attachment #8370596 - Flags: review?(gps) → review+
Comment on attachment 8370596 [details] [diff] [review]
Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

There are actually a few differences between what is in toplevel and in js/src that make this not entirely a straightforward copy and paste. I'd prefer if you looked more closely.
Attachment #8370596 - Flags: review+ → review?(gps)
Blocks: 969164
Comment on attachment 8370596 [details] [diff] [review]
Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

Review of attachment 8370596 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8840,5 @@
>      #
>      #   Android:  bug 864843
>      #   B2G:      bug 866301
> +    _INTL_API=no
> +fi

Isn't this something that should be in config.sh? meh

::: js/src/configure.in
@@ +4219,5 @@
>  dnl ========================================================
>  dnl ECMAScript Internationalization API Support (uses ICU)
>  dnl ========================================================
> +
> +_INTL_API=yes

Might want to drop a comment in here that the main configure.in overrides this with --without-intl-api. But if this file is getting killed soon, meh.
Attachment #8370596 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/6e75f48dd0cf
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.