946687 - Refactor the ICU detection rules from configure.in and js/src/configure.in into build/autoconf/icu.m4

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(no longer active)]

This is a follow-up to bug 915735 to move the rest of that code into icu.m4.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8370596 [details] [diff] [review]
Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

Review of attachment 8370596 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me on the assumption you just moved a lot of code around.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8370596 [details] [diff] [review]
Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

There are actually a few differences between what is in toplevel and in js/src that make this not entirely a straightforward copy and paste. I'd prefer if you looked more closely.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8370596 [details] [diff] [review]
Move ICU detection from configure.in and js/src/configure.in into build/autoconf/icu.m4

Review of attachment 8370596 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +8840,5 @@
>      #
>      #   Android:  bug 864843
>      #   B2G:      bug 866301
> +    _INTL_API=no
> +fi

Isn't this something that should be in config.sh? meh

::: js/src/configure.in
@@ +4219,5 @@
>  dnl ========================================================
>  dnl ECMAScript Internationalization API Support (uses ICU)
>  dnl ========================================================
> +
> +_INTL_API=yes

Might want to drop a comment in here that the main configure.in overrides this with --without-intl-api. But if this file is getting killed soon, meh.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6e75f48dd0cf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e75f48dd0cf