946753 - Marionette doesn't report error if the test script in manifest is missing

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Edgar Chen [:edgar]]

In bug 875721, the dom/network/tests/marionette/test_mobile_iccinfo.js was moved to dom/icc/tests/marionette/test_icc_info.js without correcting the manifest. But Marionette doesn't report error if the test script in manifest is missing. It will be great if marionette can report error for this situation, so this kinds of missing can be detected.

Thanks

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

To let marionette can detect missing file, maybe we should not filter out non-existed file in |TestManifest.active_tests()| by passing argument |exists| with True.

Comment 2

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8344192 [details] [diff] [review]
> Patch, v1
> 
> To let marionette can detect missing file, maybe we should not filter out
> non-existed file in |TestManifest.active_tests()| by passing argument
> |exists| with True.
                ^^^^^

Comment 3

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8344192 [details] [diff] [review]
> Patch, v1
> 
> To let marionette can detect missing file, maybe we should not filter out
> non-existed file in |TestManifest.active_tests()| by passing argument
> |exists| with True.
                ^^^^^
                Typo, it should be *False*

Comment 4

[Edgar Chen [:edgar]]

Try server: https://tbpl.mozilla.org/?tree=Try&rev=12c86480ca9d

Comment 5

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8344192 [details] [diff] [review]
Patch, v1

Review of attachment 8344192 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Edgar.

Comment 6

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/812604ada87a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/812604ada87a

Could we write a test for this?