Closed Bug 946753 Opened 6 years ago Closed 6 years ago

Marionette doesn't report error if the test script in manifest is missing

Categories

(Testing :: Marionette, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla29

People

(Reporter: edgar, Assigned: edgar)

Details

Attachments

(1 file)

In bug 875721, the dom/network/tests/marionette/test_mobile_iccinfo.js was moved to dom/icc/tests/marionette/test_icc_info.js without correcting the manifest. But Marionette doesn't report error if the test script in manifest is missing. It will be great if marionette can report error for this situation, so this kinds of missing can be detected.

Thanks
Summary: Marionette doesn't report error if the test script is missing → Marionette doesn't report error if the test script in manifest is missing
Assignee: nobody → echen
Attached patch Patch, v1Splinter Review
To let marionette can detect missing file, maybe we should not filter out non-existed file in |TestManifest.active_tests()| by passing argument |exists| with True.
Attachment #8344192 - Flags: review?(jgriffin)
(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8344192 [details] [diff] [review]
> Patch, v1
> 
> To let marionette can detect missing file, maybe we should not filter out
> non-existed file in |TestManifest.active_tests()| by passing argument
> |exists| with True.
                ^^^^^
(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8344192 [details] [diff] [review]
> Patch, v1
> 
> To let marionette can detect missing file, maybe we should not filter out
> non-existed file in |TestManifest.active_tests()| by passing argument
> |exists| with True.
                ^^^^^
                Typo, it should be *False*
Comment on attachment 8344192 [details] [diff] [review]
Patch, v1

Review of attachment 8344192 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Edgar.
Attachment #8344192 - Flags: review?(jgriffin) → review+
https://hg.mozilla.org/mozilla-central/rev/812604ada87a

Could we write a test for this?
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.