Trying to fix intermittents in apps/system/test/marionette/edges_gesture_test.js

RESOLVED FIXED

Status

Firefox OS
Gaia::System::Window Mgmt
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: etienne, Assigned: etienne)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
etienne
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
Doesn't happen that often but it can't hut.
(Assignee)

Updated

4 years ago
Blocks: 918792
(Assignee)

Comment 1

4 years ago
Created attachment 8343140 [details] [review]
Pointer to gaia PR

(test-only diff)
Assignee: nobody → etienne
Attachment #8343140 - Flags: review?(alive)
Comment on attachment 8343140 [details] [review]
Pointer to gaia PR

That sounds a sad bug for marionatte and looks like this may occur to all tests?
Can we have a followup bug for guys working on js-marionatte to fix it?
Attachment #8343140 - Flags: review?(alive) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Alive Kuo [:alive][NEEDINFO] from comment #2)
> Comment on attachment 8343140 [details] [review]
> Pointer to gaia PR
> 
> That sounds a sad bug for marionatte and looks like this may occur to all
> tests?
> Can we have a followup bug for guys working on js-marionatte to fix it?

Yes, I'm mainly waiting to see if this is actually helping :)
(Assignee)

Comment 4

4 years ago
> Yes, I'm mainly waiting to see if this is actually helping :)

Apparently it is not :)
(the travis run for the PR had the same intermittent).

Back to the drawing board.
(Assignee)

Updated

4 years ago
Attachment #8343140 - Attachment is obsolete: true
(Assignee)

Comment 5

4 years ago
Mmmhhh... I do have a new idea. will come up with a new patch soon.
(Assignee)

Comment 6

4 years ago
Created attachment 8344746 [details] [review]
Gaia PR

Take #2.

The suite was failing differently with the previous patch, but the common denominator was that we were always failing at the beginning of a test (where we usually assert that the calendar app is displayed, which is the state at the end of the setup).

Now properly waiting for the things to settle at the end of the setup function.
Attachment #8344746 - Flags: review?(alive)
Landed to be able to reopen the tree:
https://github.com/mozilla-b2g/gaia/commit/e42844c33b961010f797d39527c11bdbd26fab30

Please file followup PR for review comments.
Comment on attachment 8344746 [details] [review]
Gaia PR

Landed so canceled
Attachment #8344746 - Flags: review?(alive)
(Assignee)

Comment 9

4 years ago
Comment on attachment 8344746 [details] [review]
Gaia PR

Not a big deal.

But marking this as r=gwagner since Alive didn't got a chance to see the patch before it was landed.
Attachment #8344746 - Flags: review+
(Assignee)

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.