Closed Bug 946809 Opened 8 years ago Closed 7 years ago

The EdgeSwipeDetector should ignore touch events with more than one touch

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: etienne, Assigned: etienne)

References

Details

(Whiteboard: [systemsfe][p=5])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
When doing a pinch gesture on a phone it's pretty easy to touch the edges.

We can easily fix this by ignoring events with more than one touch since the edge gestures only use 1 finger (but pinching always 2).
Whiteboard: [mentor=etienne]
Whiteboard: [mentor=etienne] → [systemsfe][p=5]
Taking because this is will be needed soon.
Assignee: nobody → etienne
Attached file Gaia PR
Attachment #8379113 - Flags: review?(timdream)
Comment on attachment 8379113 [details] [review]
Gaia PR

I am not sure I understand this file well enough to review this....

Is Vivien not available?
Attachment #8379113 - Flags: review?(timdream)
Comment on attachment 8379113 [details] [review]
Gaia PR

No worries, Vivien should be back on Monday if he wasn't attacked by a wolf :)
Attachment #8379113 - Flags: review?(21)
Comment on attachment 8379113 [details] [review]
Gaia PR

No more breaking of pinch-to-zoom!
Attachment #8379113 - Flags: review?(21) → review+
https://github.com/mozilla-b2g/gaia/commit/ff53e9a2cf3fb0d65b37831fb5bab6286a9f5d9a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.