946823 - Automatic updates for new comments when viewing a discussion

Status: VERIFIED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

Ideally, you shouldn't have to refresh the page to see new comments appearing.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/b459b8932aa8333ebd63c30b0592c66cbc8dd56a
fixes bug 946823 - Automatic updates for new comments when viewing a discussion

Comment 2

[Peter Bengtsson [:peterbe]]

Richard, this one would love some verification attention. 

What it basically does is that it reloads all the comments (without refreshing the page) automatically. 
But...

If you are looking at the comments and you're not logged in (e.g. a new Private Window) then it shouldn't update if a new comment is posted but not yet approved. 
However, if you're looking at it and you're signed in as a moderator (or superuser) it should refresh automatically even on newly posted comments (...that aren't yet approved). 

It checks every 5 seconds.

Comment 3

[Richard A Milewski[:richard]]

Hmmm.... OK.  I'll try to verify it the next time I'm sitting down at two or more machines.

Comment 4

[Peter Bengtsson [:peterbe]]

You don't need two machines. What I do is that I either use Chrome for the second window. That or I start a second "Private Window" in Firefox.

Comment 5

[Richard A Milewski[:richard]]

Encountered an interesting problem trying to test this.    In a private browsing window I logged in using my vouched mozillian email ([e-mail]).  Air-dev tells me I"m authenticated but not vouched for, while mozillians.org show that id as vouched by Benjamin Sternthal. 

I get the same error attempting to log in with that ID from Safari.

Do we have an issue authenticating vouched mozillians?

Comment 6

[Richard A Milewski[:richard]]

The automatic updates seem to work as described.  Note, however, that unapproving a comment does not remove it from visibility at the next 5-second update.  The newly unapproved comment remains visible until the next page refresh.

Comment 7

[Peter Bengtsson [:peterbe]]

(In reply to Richard A Milewski[:richard] from comment #6)
> The automatic updates seem to work as described.  Note, however, that
> unapproving a comment does not remove it from visibility at the next
> 5-second update.  The newly unapproved comment remains visible until the
> next page refresh.

Hmm... Isn't that a bug then? Curious why you changed it to verified.