Closed
Bug 946843
Opened 11 years ago
Closed 11 years ago
XDR save the column of JSScript.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: nbp, Assigned: nbp)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
2.63 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Currently XDR scripts are saved, but we do not restore the column number, this is not important yet, but this is inconsistent and would be a problem if we relazify the JSScript, as we would no longer be able to delazify them anymore. This patch code the column number as part of XDRScript.
Attachment #8343214 -
Flags: review?(luke)
|
||
Updated•11 years ago
|
Attachment #8343214 -
Flags: review?(luke) → review+
|
|
||
Comment 1•11 years ago
|
||
Oops, I meant to add: don't forget to bump the XDR version number in Xdr.h.
|
Assignee | |
Comment 2•11 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&showall=1&rev=880434d6f5d6 https://hg.mozilla.org/integration/mozilla-inbound/rev/95efd20ead47
https://hg.mozilla.org/mozilla-central/rev/95efd20ead47
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•