946862 - Disable overscroll on OS X in Nightly until it's implemented like bug 939480 suggests

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We take a big framerate hit when ever we do overscroll as it is currently implemented. This totally ruins the effect and I feel like it's unshippable with the current implementation. Given that, I think it makes the most sense to disable it now and re-enable it once we have something performant.

Comment 1

[Stephen A Pohl [:spohl]]

Agreed. Bug 860493 is #ifndef RELEASE_BUILD until we deem this shippable.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Sorry, I meant for us to disable it on Nightly.

Comment 3

[Stephen A Pohl [:spohl]]

Attachment: Patch

That sounds reasonable.

Comment 4

[Stephen A Pohl [:spohl]]

Thanks, Felipe!

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c645ff95f2c

Comment 5

[(no longer active)]

Aren't horizontal swipes affected by the same problem though?

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> Aren't horizontal swipes affected by the same problem though?

For vertical swipes, we clearly don't do what other browsers do right now. For horizontal swipes, I think the only place we might be behaving differently is when only one page is in history, i.e. we show the grey background when overscrolling instead of the next of previous page. I might be missing something, though.

Comment 7

[(no longer active)]

(In reply to comment #6)
> (In reply to :Ehsan Akhgari (needinfo? me!) from comment #5)
> > Aren't horizontal swipes affected by the same problem though?
> 
> For vertical swipes, we clearly don't do what other browsers do right now. For
> horizontal swipes, I think the only place we might be behaving differently is
> when only one page is in history, i.e. we show the grey background when
> overscrolling instead of the next of previous page. I might be missing
> something, though.

We have terrible jank on both vertical and horizontal swipes as far as I can tell.  The number of pages in your history doesn't really make a differnece.

Comment 8

[Stephen A Pohl [:spohl]]

Are you saying that you'd like to see bug 860493 backed out for nightly and aurora? Let's take the discussion there and figure this out. The fixes for vertical and horizontal jank will be different, so the patch here is still necessary to keep the two separate. Jank during horizontal swipes has a good chance of getting fixed/reduced by bug 933389.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c645ff95f2c

Comment 10

[Bogdan Maris, Desktop Test Engineering]

I modified 'browser.snapshots.limit' in order to activate overscolling and confirm that vertical overscrolling is disabled. My testing was done on Mac OS X 10.9.1 using Firefox 28 beta 8, latest Aurora and latest Nightly.