946873 - Clicking on the borders of bookmarks widget in the panel makes a panel appear

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[u428464]

I ran into a strange issue. When you have the bookmarks widget into the menu panel and you click on the borders on top and at the bottom of it the bookmarks panel pop up out of nowhere at the bottom left of the window.

Comment 1

[Paul Silaghi, QA [:pauly]]

Attachment: bookmark button.png

Confirmed 29.0a1 (2013-12-15), Win 7 x64

Comment 2

[u428464]

Now it appears attached to the widget but this isn't fixed.

Comment 3

[u428464]

I think it should be more than just a [P4]. It's very disconcerting for the user to have this behaviour in the panel.

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

Likely a new bug, but I just tested this using the latest Tinderbox build on win7 x64 win32 m-c and after moving the Bookmark Icon to the MenuPanel through Customize, closing the Customize Panel, then opening the MenuPanel and clicking on the Bookmark Star - absolutely nothing happens, no display of bookmarks list or Bookmarks Library..

tested on m-c cset: https://hg.mozilla.org/mozilla-central/rev/d09f9a9f81ae

Comment 5

[u428464]

(In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #4)
> Likely a new bug, but I just tested this using the latest Tinderbox build on
> win7 x64 win32 m-c and after moving the Bookmark Icon to the MenuPanel
> through Customize, closing the Customize Panel, then opening the MenuPanel
> and clicking on the Bookmark Star - absolutely nothing happens, no display
> of bookmarks list or Bookmarks Library..
> 
> tested on m-c cset: https://hg.mozilla.org/mozilla-central/rev/d09f9a9f81ae

Can confirm yes.

Comment 6

[:Gijs (he/him)]

(In reply to Guillaume C. [:ge3k0s] from comment #5)
> (In reply to Jim Jeffery not reading bug-mail 1/2/11 from comment #4)
> > Likely a new bug, but I just tested this using the latest Tinderbox build on
> > win7 x64 win32 m-c and after moving the Bookmark Icon to the MenuPanel
> > through Customize, closing the Customize Panel, then opening the MenuPanel
> > and clicking on the Bookmark Star - absolutely nothing happens, no display
> > of bookmarks list or Bookmarks Library..
> > 
> > tested on m-c cset: https://hg.mozilla.org/mozilla-central/rev/d09f9a9f81ae
> 
> Can confirm yes.

This is a different bug. Filed bug 966684.

Comment 7

[:Gijs (he/him)]

Attachment: fix Australis bookmarks menu button (literal) edgecase,

Comment 8

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8381325 [details] [diff] [review]
fix Australis bookmarks menu button (literal) edgecase,

Review of attachment 8381325 [details] [diff] [review]:
-----------------------------------------------------------------

This is awful. Well done.

Comment 9

[Marco Bonardo [:mak]]

please don't use XXX comments in places code, either a normal comment, or a
// TODO (bug 123456): description

Comment 10

[:Gijs (he/him)]

(In reply to Marco Bonardo [:mak] from comment #9)
> please don't use XXX comments in places code, either a normal comment, or a
> // TODO (bug 123456): description

Switched to a normal comment.

remote:   https://hg.mozilla.org/integration/fx-team/rev/6a246a9e1c0c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6a246a9e1c0c

Comment 12

[:Gijs (he/him)]

Comment on attachment 8381325 [details] [diff] [review]
fix Australis bookmarks menu button (literal) edgecase,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: In some cases the bookmarks button won't work well when clicked while it's in the panel
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): relatively low
String or IDL/UUID changes made by this patch: none

Comment 13

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/89369bc3f91f

Comment 14

[Andrei Vaida [:avaida]]

I was able to confirm the fix for this bug on the latest Nightly (Build ID: 20140310030201) and Aurora (Build ID: 20140310004003), using:
- Windows 7 64-bit [1],
- Ubuntu 12.04 32-bit [2],
- Mac OS X 10.9.1 [3].

1. Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:30.0) Gecko/20100101 Firefox/30.0
2. Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
3. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0