Closed Bug 946878 Opened 6 years ago Closed 6 years ago

Don't pass unknown options over to jemalloc configure

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla28

People

(Reporter: wuno, Assigned: wuno)

References

Details

Attachments

(1 file)

currently after
running /bin/sh /var/tmp/portage/www-client/firefox-25.0.1/work/mozilla-release/memory/jemalloc/src/configure  --enable-application=browser --enable-optimize --with-system-jpeg --with-system-zlib --enable-pango --enable-system-cairo --disable-pedantic --disable-updater --disable-strip --disable-install-strip --disable-profilelocking --enable-default-toolkit=cairo-gtk2 --enable-official-branding --enable-dbus --disable-debug --disable-tests --disable-debug-symbols --enable-startup-notification --enable-system-sqlite --disable-necko-wifi --enable-ogg --enable-wave --with-system-libvpx --with-system-nspr --with-nspr-prefix=/usr --with-system-nss --with-nss-prefix=/usr --x-includes=/usr/include --x-libraries=/usr/lib64 --with-system-libevent=/usr --enable-system-hunspell --disable-gnomevfs --disable-gnomeui --enable-gio --disable-crashreporter --enable-jemalloc --enable-replace-malloc --prefix=/usr --libdir=/usr/lib64 --disable-gconf --disable-mailnews --with-system-png --enable-system-ffi --with-default-mozilla-five-home=/usr/lib64/firefox --target=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --enable-gstreamer --enable-pulseaudio --enable-system-cairo --enable-system-sqlite --with-system-jpeg --with-system-icu --enable-intl-api --enable-ion --enable-extensions=default --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --enable-stats --with-jemalloc-prefix=je_ ac_cv_func_memalign=yes ac_cv_func_valloc=yes --with-mangling=malloc_usable_size:replace_malloc_usable_size,valloc:replace_valloc,memalign:replace_memalign,free:replace_free,realloc:replace_realloc,calloc:replace_calloc,aligned_alloc:replace_aligned_alloc,posix_memalign:replace_posix_memalign,malloc:replace_malloc AS='$(CC)' CC='x86_64-pc-linux-gnu-gcc' CXX='x86_64-pc-linux-gnu-g++' CPP='x86_64-pc-linux-gnu-gcc -E' LD='x86_64-pc-linux-gnu-ld' AR='ar' RANLIB='ranlib' STRIP='strip' CPPFLAGS='' EXTRA_CFLAGS='-Wall -Wpointer-arith -Wdeclaration-after-statement -Werror=return-type -Wtype-limits -Wempty-body -Wsign-compare -Wno-unused -Wcast-align -march=btver1 -pipe -floop-interchange -ftree-loop-distribution -floop-strip-mine -floop-block -ftree-vectorize -mno-avx -std=gnu99 -fgnu89-inline -fno-strict-aliasing -ffunction-sections -fdata-sections -pthread -pipe' LDFLAGS='-lpthread -Wl,-O1 -Wl,--as-needed -Wl,--sort-common -Wl,-z,noexecstack -Wl,-z,text' --cache-file=/var/tmp/portage/www-client/firefox-25.0.1/work/mozilla-release/obj-x86_64-pc-linux-gnu/memory/jemalloc/src/config.cache --srcdir=/var/tmp/portage/www-client/firefox-25.0.1/work/mozilla-release/memory/jemalloc/src

jemalloc configure complains (and clutters the log file)

configure: WARNING: unrecognized options: --enable-application, --enable-optimize, --with-system-jpeg, --with-system-zlib, --enable-pango, --enable-system-cairo, --disable-pedantic, --disable-updater, --disable-strip, --disable-install-strip, --disable-profilelocking, --enable-default-toolkit, --enable-official-branding, --enable-dbus, --disable-tests, --disable-debug-symbols, --enable-startup-notification, --enable-system-sqlite, --disable-necko-wifi, --enable-ogg, --enable-wave, --with-system-libvpx, --with-system-nspr, --with-nspr-prefix, --with-system-nss, --with-nss-prefix, --with-system-libevent, --enable-system-hunspell, --disable-gnomevfs, --disable-gnomeui, --enable-gio, --disable-crashreporter, --enable-jemalloc, --enable-replace-malloc, --disable-gconf, --disable-mailnews, --with-system-png, --enable-system-ffi, --with-default-mozilla-five-home, --enable-gstreamer, --enable-pulseaudio, --enable-system-cairo, --enable-system-sqlite, --with-system-jpeg, --with-system-icu, --enable-intl-api, --enable-ion, --enable-extensions

since all of unnecessary mozilla configure options are passed over. This can be avoided by not using $_SUBDIR_CONFIG_ARGS when calling jemalloc configure
Attachment #8343249 - Flags: review?(mh+mozilla)
Assignee: nobody → wuno
Blocks: jemalloc3
Attachment #8343249 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b76e788fa217
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.