Closed Bug 946895 Opened 6 years ago Closed 6 years ago
_database .js is missing most of the list-style-type values
We're missing some regression-test and fuzzing coverage as a result of this. (I noticed this while looking at bug 934072, but it was out of date even beofre that.)
Is this patch based on a list of values from one of the CSS specs? https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type indicates that we also support some -moz- values, but I'm not sure where to look in the code for the real list.
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3) > http://hg.mozilla.org/mozilla-central/file/ae2c044c6418/layout/style/ > nsCSSProps.cpp#l1234 Thanks! I'll rewrite the patch according to this file. I just wonder if we need to test the Mozilla extensions? And should I add the values with -moz- prefix if the unprefixed counterpart exists?
I think it should include all the values that we support (and no others).
This patch adds all supported values from nsCSSProps.cpp.
Comment on attachment 8344087 [details] [diff] [review] patch v2 Great! I think this should go through tryserver on one platform (e.g. to make sure the -moz- aliases serlialize as expected). Do you have/want tryserver access, or do you want me to push it to try for you?
Attachment #8344087 - Flags: review?(jruderman) → feedback+
Status: NEW → ASSIGNED
Thanks to both of you for getting this fixed.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.