946895 - property_database.js is missing most of the list-style-type values

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

We're missing some regression-test and fuzzing coverage as a result of this.

(I noticed this while looking at bug 934072, but it was out of date even beofre that.)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Jesse Ruderman]

Is this patch based on a list of values from one of the CSS specs?

https://developer.mozilla.org/en-US/docs/Web/CSS/list-style-type indicates that we also support some -moz- values, but I'm not sure where to look in the code for the real list.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/file/ae2c044c6418/layout/style/nsCSSProps.cpp#l1234

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3)
> http://hg.mozilla.org/mozilla-central/file/ae2c044c6418/layout/style/
> nsCSSProps.cpp#l1234

Thanks! I'll rewrite the patch according to this file.
I just wonder if we need to test the Mozilla extensions? And should I add the values with -moz- prefix if the unprefixed counterpart exists?

Comment 5

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think it should include all the values that we support (and no others).

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch v2

This patch adds all supported values from nsCSSProps.cpp.

Comment 7

[Jesse Ruderman]

Comment on attachment 8344087 [details] [diff] [review]
patch v2

Great!

I think this should go through tryserver on one platform (e.g. to make sure the -moz- aliases serlialize as expected).  Do you have/want tryserver access, or do you want me to push it to try for you?

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

https://tbpl.mozilla.org/?tree=Try&rev=c5684a2bbc99

Comment 9

[Jesse Ruderman]

https://hg.mozilla.org/integration/mozilla-inbound/rev/298fa4d5c72e

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Thanks to both of you for getting this fixed.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/298fa4d5c72e