946905 - [e10s] Tab Mix Plus's Lock Tab feature does not work

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Chris Peterson [:cpeterson]]

Tab Mix Plus's Lock Tab feature should open links in a new tab instead of the locked tab, but it does not work in e10s. Clicked links open in the current, locked tab.

To enable Lock Tab, you need to open Tab Mix Plus's preferences from about:addons (because of an Australis incompatibility that prevents right-clicking the tab to get

Comment 1

[Allison Naaktgeboren :ally]

taking for investigation & retesting

Comment 2

[tabmix.onemen]

In order to fix this i need to add frame script that listen to click event on link before the build in ClickEventHandler (browser/content.js) handel the event

then i can add sendAsyncMessage("Content:Click", json) with modified json that force the link to open in new tab.

i have the patch almost ready.

i still have few problems, for examples links in google search don't fire the click event so my frame script can't handle click on google

does any of you know the cause to this?

Comment 3

[Chris Peterson [:cpeterson]]

onemen: That's great news. :) You can also get e10s help in the #e10s IRC channel on irc.mozilla.org.

Ally: Do you have any recommendations for the "links without clink event" problem onemen is debugging? I assume this problem is related to Google's SERP URL redirection loading the real URLs programmatically and maybe not generating click events.

Comment 4

[tabmix.onemen]

This code doesn't work for google search result page click event never fire
>   
>   let global = this;
>   
>   let TabmixClickEventHandler = {
>     init: function init() {
>       Cc["@mozilla.org/eventlistenerservice;1"]
>         .getService(Ci.nsIEventListenerService)
>         .addSystemEventListener(global, "click", this, true);
>     },
>
>     handleEvent: function(event) {
>

This code work as expected
>   
>   let global = this;
>   
>   let TabmixClickEventHandler = {
>     init: function init() {
>       global.addEventListener("click", this, true);
>     },
>
>     handleEvent: function(event) {
>

Comment 5

[Allison Naaktgeboren :ally]

addEventListener is shimmed to work for addons when browser.tabs.autostart=true, addSystemEventListener is not.

Stick with the second form and you should be good.

Comment 6

[Allison Naaktgeboren :ally]

though they look like they should be functionally equivalent, so it might be worthwhile to shim it anyway.

Comment 7

[tabmix.onemen]

try latest Tab Mix's development build

https://addons.mozilla.org/en-us/firefox/addon/tab-mix-plus/versions/

let me know if you find more e10s related bugs in Tab Mix

Comment 8

[Allison Naaktgeboren :ally]

looking good! Thanks for being so cooperative. I really appreciate it.

Comment 9

[Kevin Trumbull]

Is there something keeping the e10s fixes from being integrated into the mainstream release?

I was about to report that it still wasn't working on OSX, when I noticed the link to the development build.  If the issue with mainstreaming it is related to a lack of testing on stable releases, I'll do what I can to help with that...

Comment 10

[tabmix.onemen]

(In reply to Kevin Trumbull from comment #9)
> Is there something keeping the e10s fixes from being integrated into the
> mainstream release?
> 
> I was about to report that it still wasn't working on OSX, when I noticed
> the link to the development build.  If the issue with mainstreaming it is
> related to a lack of testing on stable releases, I'll do what I can to help
> with that...

This bug was fixed a year ago!

If you have any issue with Tabmix today you should report about it in Tabmix forum http://tmp.garyr.net/forum/

It is recommended to test the latest development build before posting a bug report.
you can download the latest development build from here: https://addons.mozilla.org/en-us/firefox/addon/tab-mix-plus/versions/

Comment 11

[Orb]

Tab Lock Not working again FF 48.0.2

Comment 12

[tabmix.onemen]

(In reply to Orb from comment #11)
> Tab Lock Not working again FF 48.0.2

This is not the place to report about extensions bugs

Report about it in Tab mix plus forum http://tabmixplus.org/forum/