Closed Bug 946958 Opened 6 years ago Closed 6 years ago

Tidy up LayerManagerComposite

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: nrc, Assigned: nrc)

Details

(Whiteboard: [qa-])

Attachments

(5 files)

What with LayerManagerOGL going away and all the churn in layers at the moment, it turns out there is a fair bit of tidying up (minor refactorings) to be done in and around LayerManagerComposite.
Attachment #8344388 - Flags: review?(matt.woodrow)
Attachment #8344390 - Flags: review?(matt.woodrow)
Attachment #8344391 - Flags: review?(bugmail.mozilla)
Attachment #8344392 - Flags: review?(matt.woodrow)
Attachment #8344388 - Flags: review?(matt.woodrow) → review+
Attachment #8344389 - Flags: review?(matt.woodrow) → review+
Attachment #8344390 - Flags: review?(matt.woodrow) → review+
Attachment #8344392 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8344391 [details] [diff] [review]
Part 4 - Tidy up interaction with widgets

Review of attachment 8344391 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/GLManager.cpp
@@ +55,5 @@
> +  if (Compositor::GetBackend() == LAYERS_OPENGL) {
> +    return new GLManagerCompositor(static_cast<CompositorOGL*>(
> +      aManager->GetCompositor()));
> +  } else {
> +    return nullptr;

Style nit on pre-existing code: remove the else since it's after a return statement anyway.
Attachment #8344391 - Flags: review?(bugmail.mozilla) → review+
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/45193a6d7994 for extreme displeasure on the part of reftest-ipc
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.