946991 - Schedule debug b2g emulator xpcshell tests on all trunk branches

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Debug xpcshell tests are running green on cedar. There aren't many tests, but we should enable them on other branches so they could at least catch startup crashes.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - enable debug emulator xpcshell

I'm assuming we don't want debug unittests on older branches in general, so I added an exception for that. I'm also assuming that that list of older branches is up to date.

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8345290 [details] [diff] [review]
Patch 1.0 - enable debug emulator xpcshell

  File "/Users/asasaki/wrk/virtualenv/bb08/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/scripts/runner.py", line 1042, in doCheckConfig
    ConfigLoader(configFileName=configFileName)
  File "/Users/asasaki/wrk/virtualenv/bb08/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/scripts/checkconfig.py", line 31, in __init__
    self.loadConfig(configFile, check_synchronously_only=True)
  File "/Users/asasaki/wrk/virtualenv/bb08/lib/python2.7/site-packages/buildbot-0.8.2_hg_0ba2f2a46a93_production_0.8-py2.7.egg/buildbot/master.py", line 652, in loadConfig
    exec f in localDict
  File "/src/ahal/buildbot-configs/test-output/bm51-tests1-linux-sKu0Iq/master.cfg", line 146, in <module>
    B2G_BRANCH_UNITTEST_VARS['platforms'])
  File "/src/ahal/buildbotcustom/misc.py", line 1950, in generateTalosBranchObjects
    for suites_name, suites in branch_config['platforms'][platform][slave_platform][unittest_suites]:
ValueError: need more than 1 value to unpack

I'm going to guess we're enabling debug tests on at least one branch that has no debug unittests defined.

Also, there was slight bitrot in this patch... I had to manually edit to apply the patch.

Comment 3

[Aki Sasaki (not active)]

Comment on attachment 8345290 [details] [diff] [review]
Patch 1.0 - enable debug emulator xpcshell

>+            'debug_unittest_suites': [XPCSHELL],

I think this is going to create list inside a list... probably

'debug_unittest_suites': XPCSHELL[:] ?

Comment 4

[Aki Sasaki (not active)]

Attachment: builderdiff

Looks like that fixes it.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 8345290 [details] [diff] [review]
Patch 1.0 - enable debug emulator xpcshell

r=me, with the fix in comment 3.

Comment 6

[Andrew Halberstadt [:ahal]]

Oops, thanks for catching that!

Fixed:
https://hg.mozilla.org/build/buildbot-configs/rev/e018d5871563

Comment 7

[[e-mail] (:bhearsum)]

In production

Comment 8

[Andrew Halberstadt [:ahal]]

I literally just noticed that these are orange on pine and green on cedar. We may need to hide them for a short while to figure out why.

Comment 9

[Andrew Halberstadt [:ahal]]

The error got fixed by a merge from b2g-inbound. But RyanVM pointed out that we are running xpcshell in b2g26 which we shouldn't be.

Comment 10

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.1 - disable debug emulator unittests on b2g26 as well

Sorry for all the reviews!

Comment 11

[Aki Sasaki (not active)]

Comment on attachment 8346716 [details] [diff] [review]
Patch 1.1 - disable debug emulator unittests on b2g26 as well

No worries.

Comment 12

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/build/buildbot-configs/rev/70bf2aaeb5a1

Comment 13

[[e-mail] (:bhearsum)]

In production