Closed Bug 946998 Opened 6 years ago Closed 6 years ago

netwerk/ipc/NeckoParent.cpp:392:7 [-Wsometimes-uninitialized] variable 'p' is used uninitialized whenever 'if' condition is false

Categories

(Core :: WebRTC: Networking, defect)

27 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [qa-])

Attachments

(1 file)

Bug 870660 introduced these -Wsometimes-uninitialized warnings on OS X. NeckoParent::AllocPUDPSocketParent() may be able to return an uninitialized pointer.

netwerk/ipc/NeckoParent.cpp:392:7 [-Wsometimes-uninitialized] variable 'p' is used uninitialized whenever 'if' condition is false
netwerk/ipc/NeckoParent.cpp:395:9 [-Wsometimes-uninitialized] variable 'p' is used uninitialized whenever 'if' condition is false
netwerk/ipc/NeckoParent.cpp:398:11 [-Wsometimes-uninitialized] variable 'p' is used uninitialized whenever 'if' condition is false
Attachment #8343396 - Flags: review?(jduell.mcbugs)
Comment on attachment 8343396 [details] [diff] [review]
fix-Wsometimes-uninitialized-warning.patch

Review of attachment 8343396 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for catching this.
Attachment #8343396 - Flags: review?(jduell.mcbugs) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b372181af8e7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.