947101 - Rtsp: Backward seek fail.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Vincent Chang[:vchang][changyihsin]]

Sometime backward seek may fail. The content process can't receive onMediaDataAvailable event from parent process.

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

When doing the backward seek, the onTrackDataAvailable() may be skipped due to incorrect mLatestPausedUnit. The reason is that kWhatPausedDone event may arrive
after performSeek() command is executed.

Comment 2

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8343610 [details] [diff] [review]
Patch v1.0

Review of attachment 8343610 [details] [diff] [review]:
-----------------------------------------------------------------

In general, looks fine - I just have one query.

Also, while you're doing this, can you add in a couple of small fixes? In RtspSource::performPause and performSeek, RtspSource::mLatestPausedUnit is reset repeatedly inside the for loop. This only needs to be done once, outside the for loop. Can you change those lines please?

::: netwerk/protocol/rtsp/rtsp/RTSPSource.cpp
@@ +315,5 @@
> +            // because of previous performPause() command.
> +            for (size_t i = 0; i < mTracks.size(); ++i) {
> +                TrackInfo *info = &mTracks.editItemAt(i);
> +                info->mLatestPausedUnit = 0;
> +            }

Do you need to reset RtspConnectionHandler::mLatestPausedUnit here as well?

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v.1.1

Address the review comments.

Comment 4

[Vincent Chang[:vchang][changyihsin]]

This is a very important fix for Rtsp seek function. It would be better if we could land it on 1.3. 
Nominate it for madai?

Comment 5

[Steve Workman [:sworkman] (INACTIVE)]

Comment on attachment 8344434 [details] [diff] [review]
Patch v.1.1

Review of attachment 8344434 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the changes! r=me.

Comment 6

[Vincent Chang[:vchang][changyihsin]]

Try server result looks good. 
https://tbpl.mozilla.org/?tree=Try&rev=48638214379e

Comment 7

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.2

Rebase the patch.

Comment 8

[Vincent Chang[:vchang][changyihsin]]

Push to b2g-inbound
https://hg.mozilla.org/integration/b2g-inbound/rev/49cb8e873bc1

Comment 9

[Vincent Chang[:vchang][changyihsin]]

Rtsp should be landed to 1.3, and seek is the basic function of Rtsp streaming.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/49cb8e873bc1

Comment 11

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

RTSP defect to be fixed in 1.3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b0b118d4ec72