947115 - native key event handling tests should use synthesizeNativeKey of EventUtils

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The second patch of bug 930374 introduces synthesizeNativeKey of EventUtils. All tests testing native key event handling should use it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Mac's French keyboard case for Mac of test_keycodes.xul hasn't work! This also fixes the bug and add tests for it.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8344650 [details] [diff] [review]
Patch

Hmm, this is a massive patch.

Could you explain the changes to TextInputHandler.mm.
Do those affect to tests only?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8344650 [details] [diff] [review]
> Patch
> 
> Hmm, this is a massive patch.
> 
> Could you explain the changes to TextInputHandler.mm.
> Do those affect to tests only?

Yes, it runs only when nsIDOMWindowUtils::SendNativeKeyEvent() is called. The method loads a keyboard layout from the specified integer value which is defined by us. At handling native keyboard events, TextInputHanlder gets keyboard layout information with other APIs which get _current_ state.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8344650 [details] [diff] [review]
Patch

rs=me, make sure to run these tests few times on try before landing.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2700df154644

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=7e8eb5f4217e

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2700df154644