Closed Bug 947115 Opened 6 years ago Closed 6 years ago

native key event handling tests should use synthesizeNativeKey of EventUtils

Categories

(Core :: User events and focus handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(1 file)

The second patch of bug 930374 introduces synthesizeNativeKey of EventUtils. All tests testing native key event handling should use it.
Attached patch PatchSplinter Review
Mac's French keyboard case for Mac of test_keycodes.xul hasn't work! This also fixes the bug and add tests for it.
Attachment #8344650 - Flags: review?(bugs)
Comment on attachment 8344650 [details] [diff] [review]
Patch

Hmm, this is a massive patch.

Could you explain the changes to TextInputHandler.mm.
Do those affect to tests only?
(In reply to Olli Pettay [:smaug] from comment #2)
> Comment on attachment 8344650 [details] [diff] [review]
> Patch
> 
> Hmm, this is a massive patch.
> 
> Could you explain the changes to TextInputHandler.mm.
> Do those affect to tests only?

Yes, it runs only when nsIDOMWindowUtils::SendNativeKeyEvent() is called. The method loads a keyboard layout from the specified integer value which is defined by us. At handling native keyboard events, TextInputHanlder gets keyboard layout information with other APIs which get _current_ state.
Comment on attachment 8344650 [details] [diff] [review]
Patch

rs=me, make sure to run these tests few times on try before landing.
Attachment #8344650 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/2700df154644
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.