947152 - [evme] Do not print debug message by default

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

[EVME migration] migrating from 1.0.1 to 1.1...
[EVME migration] [userHistory]: retrieving...
[EVME migration] [userHistory]: no value
[EVME migration] [localShortcuts]: retrieving...
[EVME migration] [localShortcuts]: no value
[EVME migration] [localShortcutsIcons]: retrieving...
[EVME migration] [localShortcutsIcons]: no value
[EVME migration] complete successfully!
[EVME migration] migrating from 1.0.1 to 1.1...
[EVME migration] [userHistory]: retrieving...
[EVME migration] [userHistory] got value: no json, should give error but continue
[EVME migration] [localShortcuts]: retrieving...
[EVME migration] [localShortcuts] got value: {"_v": "shortcuts json with value"}
[EVME migration] [localShortcuts:evme-localShortcuts]: saving: {"value":"shortcuts json with value"}
[EVME migration] [localShortcuts:evme-localShortcuts]: saved, remove old data
[EVME migration] [localShortcutsIcons]: retrieving...
[EVME migration] [localShortcutsIcons] got value: {"_v": "icons json with value"}
[EVME migration] [localShortcutsIcons:evme-localShortcutsIcons]: saving: {"value":"icons json with value"}
[EVME migration] [localShortcutsIcons:evme-localShortcutsIcons]: saved, remove old data
[EVME migration] complete successfully!

Comment 1

[Ran Ben Aharon [:ranbena] EverythingMe]

Didn't know you guys prefer log suppression. I'll create a patch.

Comment 2

[Amir Nissim (:amirn)]

Attachment: Redirect to PR

Everything.me logs will print only when custom settings file exists.

in apps/homescreen/everything.me/config/local.json:
{
  "debug": true
}

Comment 3

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/7426ac1

Comment 4

[Amir Nissim (:amirn)]

Cristian - I know you're busy so didn't want to bother you with this review (it's mostly internal E.me).
If you do find the time to review it I can make followup changes in another bug.