Closed Bug 947257 Opened 6 years ago Closed 6 years ago

Splitters have a dark squary sort of thing in their center

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 28

People

(Reporter: vporof, Assigned: bgrins)

Details

(Whiteboard: [good first verify])

Attachments

(2 files)

Happens in all tools. See screenshot.
Seems to be caused by chrome://global/skin/splitter.css with background-image: url("chrome://global/skin/splitter/dimple.png").  The background-image:none override seems to have been removed in Bug 941673.
Assignee: nobody → bgrinstead
Paul, this fixes the issue - but one thing I noticed is that this override was previously only in place for OSX.  I guess on Windows and Linux it allowed the background image to stay (or maybe it was never set in the first place?).  You can see that osx is the only one with background-image:none by searching for devtools-side-splitter on the original patch: https://bugzilla.mozilla.org/attachment.cgi?id=8341091&action=diff.

The question is, should we still support this different behavior across OS with the preprocessor, or just use consistent styling across the board?
Attachment #8343830 - Flags: review?(paul)
Attachment #8343830 - Flags: review?(paul) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/05643bb0c75e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
Whiteboard: [good first verify]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.