Splitters have a dark squary sort of thing in their center

RESOLVED FIXED in Firefox 28

Status

RESOLVED FIXED
5 years ago
2 months ago

People

(Reporter: vporof, Assigned: bgrins)

Tracking

unspecified
Firefox 28

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first verify])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
Created attachment 8343762 [details]
Screen Shot 2013-12-06 at 17.39.03.png

Happens in all tools. See screenshot.
(Assignee)

Comment 1

5 years ago
Seems to be caused by chrome://global/skin/splitter.css with background-image: url("chrome://global/skin/splitter/dimple.png").  The background-image:none override seems to have been removed in Bug 941673.
Assignee: nobody → bgrinstead
(Assignee)

Comment 2

5 years ago
Created attachment 8343830 [details] [diff] [review]
theme-splitters.patch

Paul, this fixes the issue - but one thing I noticed is that this override was previously only in place for OSX.  I guess on Windows and Linux it allowed the background image to stay (or maybe it was never set in the first place?).  You can see that osx is the only one with background-image:none by searching for devtools-side-splitter on the original patch: https://bugzilla.mozilla.org/attachment.cgi?id=8341091&action=diff.

The question is, should we still support this different behavior across OS with the preprocessor, or just use consistent styling across the board?
Attachment #8343830 - Flags: review?(paul)

Updated

5 years ago
Attachment #8343830 - Flags: review?(paul) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/05643bb0c75e
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/05643bb0c75e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28

Updated

5 years ago
Whiteboard: [good first verify]

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.