Closed
Bug 947257
Opened 11 years ago
Closed 11 years ago
Splitters have a dark squary sort of thing in their center
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: vporof, Assigned: bgrins)
Details
(Whiteboard: [good first verify])
Attachments
(2 files)
|
20.94 KB,
image/png
|
Details | |
|
1.10 KB,
patch
|
paul
:
review+
|
Details | Diff | Splinter Review |
Screen Shot 2013-12-06 at 17.39.03.png
Happens in all tools. See screenshot.
|
Assignee | |
Comment 1•11 years ago
|
||
Seems to be caused by chrome://global/skin/splitter.css with background-image: url("chrome://global/skin/splitter/dimple.png"). The background-image:none override seems to have been removed in Bug 941673.
Assignee: nobody → bgrinstead
|
|
Assignee | |
Comment 2•11 years ago
|
||
Paul, this fixes the issue - but one thing I noticed is that this override was previously only in place for OSX. I guess on Windows and Linux it allowed the background image to stay (or maybe it was never set in the first place?). You can see that osx is the only one with background-image:none by searching for devtools-side-splitter on the original patch: https://bugzilla.mozilla.org/attachment.cgi?id=8341091&action=diff.
The question is, should we still support this different behavior across OS with the preprocessor, or just use consistent styling across the board?
Attachment #8343830 -
Flags: review?(paul)
|
||
Updated•11 years ago
|
Attachment #8343830 -
Flags: review?(paul) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 28
|
||
Updated•11 years ago
|
Whiteboard: [good first verify]
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•