Closed Bug 947259 Opened 9 years ago Closed 9 years ago

marionetteScriptFinished() has no effect in performance_helper_atom.

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86_64
Linux
Type:
defect

Tracking

(b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C1/1.4 S1(20dec)
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: hub, Assigned: hub)

References

Details

(Keywords: perf, Whiteboard: [c=automation p=2 s= u=])

Attachments

(1 file)

Pull request
46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review 
marionetteScriptFinished() has no effect in performance_helper_atom.

This is a followup from bug 915156

In tests/performance/app.js: waitForPerfEvents(), we call executeAsyncScript().
The atom is in ./tests/performance/performance_helper_atom.js, when the function finish() is called (we checked it is), marionetteScriptFinished() is called, but does nothing.

Upon closer inspection, it seems that in marionette-listener.js (Gecko) the commandId as passed to asyncComplete is different from the global asyncTestCommandId.

Note sure exactly what's happening yet, but this cause perf test to succeed on a 50s timeout.
Blocks: gaia-perf-measure
Depends on: 915156
Keywords: perf
Whiteboard: [c=automation p=2 s= u=]
Blocks: 916017
Priority: -- → P1
Assignee: nobody → hub
Status: NEW → ASSIGNED
It seems that it is a problem with order of things, aka a misunderstanding on how it works. See pull request.
Attached file Pull request — 

        Attachment #8346717 -
        Flags: review?(felash)

    
    

    
  
Comment on attachment 8346717 [details] [review]
Pull request

cancelling review due to some things I forgot.

        Attachment #8346717 -
        Flags: review?(felash)

    
  
Depends on: 949209

    
    

    
  
Comment on attachment 8346717 [details] [review]
Pull request

This time we should be good. Look ! No timeout !

        Attachment #8346717 -
        Flags: review?(felash)

    
    

    
  
Remove blocker. Isn't really blocked.
No longer depends on: 949209

    
    

    
  
Comment on attachment 8346717 [details] [review]
Pull request

Added some cleanup comments on the PR.

I admit I still don't understand how marionetteScriptFinished works but I'll trust you on this ;)

    
    

    
  
I have updated the PR addressing the cleanup comments. Travis is only perma-orange.

    
    

    
  
Comment on attachment 8346717 [details] [review]
Pull request

r=me with the 2 additional comments

        Attachment #8346717 -
        Flags: review?(felash) → review+

    
    

    
  
Merged. https://github.com/mozilla-b2g/gaia/commit/9738f1d3bff9cc8fb5c92adf2c02f53ad6a52999
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
shall we backport to 1.4? should be easy and would allow the test to run better on 1.4
blocking-b2g: --- → 1.4?

    
    

    
  
I meant 1.3?
blocking-b2g: 1.4? → 1.3?

    
    

    
  
Let's just do it, it's a=npotb (not part of the build).

John, could you assist please?
blocking-b2g: 1.3? → ---
Flags: needinfo?(jhford)

    
    

    
  
[v1.3 81af9e2] Merge pull request #14621 from hfiguiere/bug947259

          status-b2g-v1.3:
          --- → fixed
Flags: needinfo?(jhford)

    
  
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)

          You need to log in
          before you can comment on or make changes to this bug.