Closed
Bug 947259
Opened 11 years ago
Closed 11 years ago
marionetteScriptFinished() has no effect in performance_helper_atom.
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(b2g-v1.3 fixed)
RESOLVED
FIXED
1.3 C1/1.4 S1(20dec)
| Tracking | Status | |
|---|---|---|
| b2g-v1.3 | --- | fixed |
People
(Reporter: hub, Assigned: hub)
References
Details
(Keywords: perf, Whiteboard: [c=automation p=2 s= u=])
Attachments
(1 file)
marionetteScriptFinished() has no effect in performance_helper_atom.
This is a followup from bug 915156
In tests/performance/app.js: waitForPerfEvents(), we call executeAsyncScript().
The atom is in ./tests/performance/performance_helper_atom.js, when the function finish() is called (we checked it is), marionetteScriptFinished() is called, but does nothing.
Upon closer inspection, it seems that in marionette-listener.js (Gecko) the commandId as passed to asyncComplete is different from the global asyncTestCommandId.
Note sure exactly what's happening yet, but this cause perf test to succeed on a 50s timeout.
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Updated•11 years ago
|
Priority: -- → P1
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → hub
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
It seems that it is a problem with order of things, aka a misunderstanding on how it works. See pull request.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8346717 -
Flags: review?(felash)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8346717 [details] [review]
Pull request
cancelling review due to some things I forgot.
Attachment #8346717 -
Flags: review?(felash)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8346717 [details] [review]
Pull request
This time we should be good. Look ! No timeout !
Attachment #8346717 -
Flags: review?(felash)
|
||
Comment 6•11 years ago
|
||
Comment on attachment 8346717 [details] [review]
Pull request
Added some cleanup comments on the PR.
I admit I still don't understand how marionetteScriptFinished works but I'll trust you on this ;)
|
|
Assignee | |
Comment 7•11 years ago
|
||
I have updated the PR addressing the cleanup comments. Travis is only perma-orange.
|
|
||
Comment 8•11 years ago
|
||
Comment on attachment 8346717 [details] [review]
Pull request
r=me with the 2 additional comments
Attachment #8346717 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•11 years ago
|
||
shall we backport to 1.4? should be easy and would allow the test to run better on 1.4
blocking-b2g: --- → 1.4?
|
|
||
Comment 12•11 years ago
|
||
Let's just do it, it's a=npotb (not part of the build).
John, could you assist please?
blocking-b2g: 1.3? → ---
Flags: needinfo?(jhford)
|
||
Comment 13•11 years ago
|
||
[v1.3 81af9e2] Merge pull request #14621 from hfiguiere/bug947259
status-b2g-v1.3:
--- → fixed
Flags: needinfo?(jhford)
|
||
Updated•11 years ago
|
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•