947335 - "insufficient privileges" on /login/?next=/report/exploitability/

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Helmer [:rhelmer]]

Steps to reproduce:

1) log out of crash-stats
2) load https://crash-stats.mozilla.com/report/exploitability/
3) "Login Required", so login with Persona

Actual:

redirected to https://crash-stats.mozilla.com/login/?next=/report/exploitability/ with "Insufficient Privileges"

Expected:

redirected to https://crash-stats.mozilla.com/login/?next=/report/exploitability/ and shown same report as https://crash-stats.mozilla.com/report/exploitability/

Comment 1

[Peter Bengtsson [:peterbe]]

I'm able to reproduce this locally. I think the "Insufficient Privileges" message is correct. That appears if you're redirected to the /login/ page and logged in at the same time. Basically, the error is that you shouldn't be redirected there at all. I think the error is in the way we tell django-browserid which page to go to next if the login is successful.

Comment 2

[Peter Bengtsson [:peterbe]]

Attachment: Github PR

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ce091855ef76de64d8847480d9bfc89d3b2f18e4
fixes bug 947335 - bad message and redirect, r=rhelmer

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://crash-stats.allizom.org/report/exploitability/

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, on staging