947402 - --with-system-icu breaks on packaging

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jan Beich]

_virtualenv/bin/python toolkit/mozapps/installer/packager.py -DMOZ_GLUE_IN_PROGRAM -DNO_NSPR_10_SUPPORT -DAB_CD=en-US -DMOZ_APP_NAME=firefox -DPREF_DIR=defaults/preferences -DMOZ_ENABLE_GNOME_COMPONENT=1 -DMOZ_GTK=1 -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=plugin-container -DMOZ_JSDEBUGGER -DNECKO_WIFI -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DBINPATH=bin -DMOZ_ICU_VERSION=50 -DMOZ_SHARED_ICU \
        --format omni \
        --removals browser/installer/removed-files.in \
         \
         \
         \
        --optimizejars \
         \
        package-manifest ../../dist ../../dist/firefox \

Error: browser/installer/package-manifest:44: Missing file(s): bin/libicudata.so.50
Error: browser/installer/package-manifest:45: Missing file(s): bin/libicui18n.so.50
Error: browser/installer/package-manifest:46: Missing file(s): bin/libicuuc.so.50
Traceback (most recent call last):
  File "toolkit/mozapps/installer/packager.py", line 375, in <module>
    main()
  File "toolkit/mozapps/installer/packager.py", line 328, in main
    copier.add(mozpack.path.join(binpath, 'removed-files'), removals)
  File "/usr/local/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "python/mozbuild/mozpack/errors.py", line 129, in accumulate
    raise AccumulatedErrors()
mozpack.errors.AccumulatedErrors
gmake[3]: *** [stage-package] Error 1

Comment 1

[Jan Beich]

Attachment: Don't attempt to package shared ICU for --with-system-icu.

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7b670bd3c7f2

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/7b670bd3c7f2