Closed Bug 947442 Opened 8 years ago Closed 7 years ago

Perf test should fail if it didn't collect perf data

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P1)

x86_64
Linux
defect

Tracking

(b2g-v1.3T fixed)

RESOLVED FIXED
1.4 S2 (28feb)
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: hub, Assigned: hub)

References

Details

(Keywords: perf, Whiteboard: [c=automation p=2 s= u=])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
julienw
: review+
Details | Review
No description provided.
[ oop ]

Test should fail if it didn't collect perf data as lack of perf data should be a failure. Since we drive everything with Mocha is should be pretty trivial.
Assignee: nobody → hub
Keywords: perf
Summary: Test should fail if it didn → Perf test should fail if it didn't collect perf data
Whiteboard: [c=automation p= s= u=]
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [c=automation p= s= u=] → [c=automation p=2 s= u=]
I really think we should bump this to P1. It would make things so much easier.

Failures would just appear as test failures in the output.
Priority: P2 → P1
Attached file Pull request
Attachment #8373676 - Flags: review?(felash)
Comment on attachment 8373676 [details] [review]
Pull request

added comments on github

please request review again once you're ready

thanks and sorry for being late, my time was sucked up by 1.3 bugs :(
Attachment #8373676 - Flags: review?(felash)
Comment on attachment 8373676 [details] [review]
Pull request

Updated the pull request.
Attachment #8373676 - Flags: review?(felash)
Component: Gaia → Gaia::PerformanceTest
Comment on attachment 8373676 [details] [review]
Pull request

running "make test-perf" in b2g-desktop does not work anymore.

We should have a way to ignore the memory check in this case.
Attachment #8373676 - Flags: review?(felash)
Comment on attachment 8373676 [details] [review]
Pull request

Addressed the issue where the tests are run on b2g-desktop.
Attachment #8373676 - Flags: review?(felash)
Comment on attachment 8373676 [details] [review]
Pull request

looks good but I can't test today as I'm in PTO, will do Monday
Comment on attachment 8373676 [details] [review]
Pull request

r=me

note that I get 2 measurements per run when running with b2g desktop, don't know where this comes from. Since this happens on master too this is fine for this bug, but please file another bug for this.
Attachment #8373676 - Flags: review?(felash) → review+
There is something fishy.
Filed Bug 973680
Merged.

https://github.com/mozilla-b2g/gaia/commit/ae90f9b322509ee09fbd3963bd23e142845613ab
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S2 (28feb)
You need to log in before you can comment on or make changes to this bug.