Closed
Bug 947490
Opened 10 years ago
Closed 10 years ago
Fix sendKeys and the PUA keys in Marionette
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla35
People
(Reporter: automatedtester, Assigned: automatedtester)
References
(Blocks 4 open bugs)
Details
(Keywords: pi-marionette-userinput)
Attachments
(1 file, 1 obsolete file)
29.71 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
This is a continuation of the work started in bug 942730. Currently some of it works and other parts dont so need to sort but it shouldnt hold up bug 942730
Comment 1•10 years ago
|
||
Just a reminder comment to move the key mappings from marionette-listener.js to marionette-sendkeys.js
Assignee | ||
Updated•10 years ago
|
Keywords: ateam-marionette-userinput
Priority: -- → P3
Assignee | ||
Comment 2•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=d07df0cf3324
Assignee | ||
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=453c022a0e03
Assignee | ||
Comment 4•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=3cdd913404be
Assignee | ||
Comment 5•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=cba5cc47d2d3
Assignee | ||
Comment 6•10 years ago
|
||
Attachment #8491363 -
Flags: review?(jgriffin)
Comment 7•10 years ago
|
||
Comment on attachment 8491363 [details] [diff] [review] Move Marionette sendKeys code to it's own file and delete dead code Review of attachment 8491363 [details] [diff] [review]: ----------------------------------------------------------------- It's not entirely clear but it looks like we're regressing some behavior based on the tests that are disabled; is this harmless to gaiatest? If yes, then r+. ::: testing/marionette/client/marionette/tests/unit/test_typing.py @@ +200,5 @@ > element = self.marionette.find_element("id", "keyReporter") > upperAlphas = "ABCDEFGHIJKLMNOPQRSTUVWXYZ" > element.send_keys(upperAlphas) > self.assertEqual(element.get_attribute("value"), upperAlphas) > + import pdb; pdb.set_trace() should delete this pdb line
Attachment #8491363 -
Flags: review?(jgriffin) → review+
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Jonathan Griffin (:jgriffin) from comment #7) > Comment on attachment 8491363 [details] [diff] [review] > Move Marionette sendKeys code to it's own file and delete dead code > > Review of attachment 8491363 [details] [diff] [review]: > ----------------------------------------------------------------- > > It's not entirely clear but it looks like we're regressing some behavior > based on the tests that are disabled; is this harmless to gaiatest? If yes, > then r+. This is harmless to gaiatest since its cleaning up the code and making it saner. We now have more coverage than before. I have raised the relevant bugs to remind us to turn them back on.
Assignee | ||
Comment 9•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8491363 -
Attachment is obsolete: true
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8491905 [details] [diff] [review] Move Marionette sendKeys code to it's own file and delete dead code Review of attachment 8491905 [details] [diff] [review]: ----------------------------------------------------------------- Cleaned up and carrying review forward
Attachment #8491905 -
Flags: review+
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1359e352a27d
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1359e352a27d
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•