Closed Bug 947490 Opened 6 years ago Closed 5 years ago

Fix sendKeys and the PUA keys in Marionette

Categories

(Testing :: Marionette, defect, P3)

x86
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED
mozilla35

People

(Reporter: automatedtester, Assigned: automatedtester)

References

(Blocks 4 open bugs)

Details

(Keywords: pi-marionette-userinput)

Attachments

(1 file, 1 obsolete file)

This is a continuation of the work started in bug 942730. Currently some of it works and other parts dont so need to sort but it shouldnt hold up bug 942730
Depends on: 942730
Just a reminder comment to move the key mappings from marionette-listener.js to marionette-sendkeys.js
Priority: -- → P3
Blocks: 1068726
Blocks: 1068728
Blocks: 1068733
Blocks: 1068735
Comment on attachment 8491363 [details] [diff] [review]
Move Marionette sendKeys code to it's own file and delete dead code

Review of attachment 8491363 [details] [diff] [review]:
-----------------------------------------------------------------

It's not entirely clear but it looks like we're regressing some behavior based on the tests that are disabled; is this harmless to gaiatest?  If yes, then r+.

::: testing/marionette/client/marionette/tests/unit/test_typing.py
@@ +200,5 @@
>          element = self.marionette.find_element("id", "keyReporter")
>          upperAlphas = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
>          element.send_keys(upperAlphas)
>          self.assertEqual(element.get_attribute("value"), upperAlphas)
> +        import pdb; pdb.set_trace()

should delete this pdb line
Attachment #8491363 - Flags: review?(jgriffin) → review+
(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 8491363 [details] [diff] [review]
> Move Marionette sendKeys code to it's own file and delete dead code
> 
> Review of attachment 8491363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It's not entirely clear but it looks like we're regressing some behavior
> based on the tests that are disabled; is this harmless to gaiatest?  If yes,
> then r+.

This is harmless to gaiatest since its cleaning up the code and making it saner. We now have more coverage than before. I have raised the relevant bugs to remind us to turn them back on.
Attachment #8491363 - Attachment is obsolete: true
Comment on attachment 8491905 [details] [diff] [review]
Move Marionette sendKeys code to it's own file and delete dead code

Review of attachment 8491905 [details] [diff] [review]:
-----------------------------------------------------------------

Cleaned up and carrying review forward
Attachment #8491905 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/1359e352a27d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.