947490 - Fix sendKeys and the PUA keys in Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[David Burns :automatedtester]

This is a continuation of the work started in bug 942730. Currently some of it works and other parts dont so need to sort but it shouldnt hold up bug 942730

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Just a reminder comment to move the key mappings from marionette-listener.js to marionette-sendkeys.js

Comment 2

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=d07df0cf3324

Comment 3

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=453c022a0e03

Comment 4

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=3cdd913404be

Comment 5

[David Burns :automatedtester]

https://tbpl.mozilla.org/?tree=Try&rev=cba5cc47d2d3

Comment 6

[David Burns :automatedtester]

Attachment: Move Marionette sendKeys code to it's own file and delete dead code

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8491363 [details] [diff] [review]
Move Marionette sendKeys code to it's own file and delete dead code

Review of attachment 8491363 [details] [diff] [review]:
-----------------------------------------------------------------

It's not entirely clear but it looks like we're regressing some behavior based on the tests that are disabled; is this harmless to gaiatest?  If yes, then r+.

::: testing/marionette/client/marionette/tests/unit/test_typing.py
@@ +200,5 @@
>          element = self.marionette.find_element("id", "keyReporter")
>          upperAlphas = "ABCDEFGHIJKLMNOPQRSTUVWXYZ"
>          element.send_keys(upperAlphas)
>          self.assertEqual(element.get_attribute("value"), upperAlphas)
> +        import pdb; pdb.set_trace()

should delete this pdb line

Comment 8

[David Burns :automatedtester]

(In reply to Jonathan Griffin (:jgriffin) from comment #7)
> Comment on attachment 8491363 [details] [diff] [review]
> Move Marionette sendKeys code to it's own file and delete dead code
> 
> Review of attachment 8491363 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It's not entirely clear but it looks like we're regressing some behavior
> based on the tests that are disabled; is this harmless to gaiatest?  If yes,
> then r+.

This is harmless to gaiatest since its cleaning up the code and making it saner. We now have more coverage than before. I have raised the relevant bugs to remind us to turn them back on.

Comment 9

[David Burns :automatedtester]

Attachment: Move Marionette sendKeys code to it's own file and delete dead code

Comment 10

[David Burns :automatedtester]

Comment on attachment 8491905 [details] [diff] [review]
Move Marionette sendKeys code to it's own file and delete dead code

Review of attachment 8491905 [details] [diff] [review]:
-----------------------------------------------------------------

Cleaned up and carrying review forward

Comment 11

[David Burns :automatedtester]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1359e352a27d

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1359e352a27d