Closed
Bug 947508
Opened 12 years ago
Closed 12 years ago
Correct assertCurrentPage output message
Categories
(Firefox for Android Graveyard :: Testing, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 28
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
bnicholson
:
review+
|
Details | Diff | Splinter Review |
The output is incorrect because we retrieve the value from the enum rather than using toString directly.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8344065 -
Flags: review?(bnicholson)
|
|
Assignee | |
Updated•12 years ago
|
OS: All → Android
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8344065 [details] [diff] [review]
Correct assertCurrentPage output.
Review of attachment 8344065 [details] [diff] [review]:
-----------------------------------------------------------------
Note that you don't really need a value in the message at all; assertEquals should say something like "X != Y", so your message could just be something like "Current HomePager page matches expected page".
Attachment #8344065 -
Flags: review?(bnicholson) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
The problem here is that they're indices, so it would say:
16:03:36 INFO - 5 INFO TEST-PASS | testAboutHomePageNavigation | The HomePager is visible - 0 should equal 0
Taken from https://tbpl.mozilla.org/php/getParsedLog.php?id=31527720&tree=Mozilla-Central#error1
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•