If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Correct assertCurrentPage output message

RESOLVED FIXED in Firefox 28

Status

()

Firefox for Android
Testing
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

Trunk
Firefox 28
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The output is incorrect because we retrieve the value from the enum rather than using toString directly.
(Assignee)

Comment 1

4 years ago
Created attachment 8344065 [details] [diff] [review]
Correct assertCurrentPage output.
Attachment #8344065 - Flags: review?(bnicholson)
(Assignee)

Updated

4 years ago
OS: All → Android
Comment on attachment 8344065 [details] [diff] [review]
Correct assertCurrentPage output.

Review of attachment 8344065 [details] [diff] [review]:
-----------------------------------------------------------------

Note that you don't really need a value in the message at all; assertEquals should say something like "X != Y", so your message could just be something like "Current HomePager page matches expected page".
Attachment #8344065 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 3

4 years ago
The problem here is that they're indices, so it would say:

16:03:36     INFO -  5 INFO TEST-PASS | testAboutHomePageNavigation | The HomePager is visible - 0 should equal 0

Taken from https://tbpl.mozilla.org/php/getParsedLog.php?id=31527720&tree=Mozilla-Central#error1
(Assignee)

Comment 4

4 years ago
remote:   https://hg.mozilla.org/integration/fx-team/rev/a7fea61a018c
https://hg.mozilla.org/mozilla-central/rev/a7fea61a018c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.