Closed Bug 947544 Opened 11 years ago Closed 7 years ago

Intermittent browser_se_bfcache.js | The vertex shader editor contains the correct text. - Got {100,170}, expected {170,100} | The fragment shader editor contains the correct text. - Got {89,97}, expected {97,89}

Categories

(DevTools Graveyard :: WebGL Shader Editor, defect, P2)

Product:
DevTools Graveyard
Component:
WebGL Shader Editor
Platform:
All
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: KWierso, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [leave open][test disabled])

Attachments

(1 file, 2 obsolete files)

shadereditor-intermittent.patch
3.12 KB, patch
vporof
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=31594083&tree=Mozilla-Inbound slave: t-xp32-ix-045 16:40:19 INFO - TEST-START | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Apparently, WebGL is supported. 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Initializing a shader editor pane. 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Adding tab: http://example.com/browser/browser/devtools/shadereditor/test/doc_simple-canvas.html 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Console message: [JavaScript Error: "A promise chain failed to handle a rejection. 16:40:19 INFO - Date: Fri Dec 06 2013 16:40:18 GMT-0800 (Pacific Standard Time) 16:40:19 INFO - Full Message: Error: Shader Editor is still waiting for a WebGL context to be created. 16:40:19 INFO - Full Stack: ShadersEditorsView._getEditor@chrome://browser/content/devtools/shadereditor.js:396 16:40:19 INFO - ShadersEditorsView._toggleListeners/<@chrome://browser/content/devtools/shadereditor.js:425 16:40:19 INFO - ShadersEditorsView._toggleListeners@chrome://browser/content/devtools/shadereditor.js:424 16:40:19 INFO - ShadersEditorsView.destroy@chrome://browser/content/devtools/shadereditor.js:355 16:40:19 INFO - shutdownShaderEditor@chrome://browser/content/devtools/shadereditor.js:75 16:40:19 INFO - ShaderEditorPanel.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shadereditor/panel.js:62 16:40:19 INFO - Toolbox.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:988 16:40:19 INFO - EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/event-emitter.js:110 16:40:19 INFO - TabTarget.prototype.destroy@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:435 16:40:19 INFO - TabTarget.prototype.handleEvent@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/target.js:396 16:40:19 INFO - " {file: "chrome://browser/content/devtools/shadereditor.js" line: 396 column: 0 source: "396"}] 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Tab added and finished loading: http://example.com/browser/browser/devtools/shadereditor/test/doc_simple-canvas.html 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'navigate' on TabTarget:[object XULElement]. 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'program-linked' on [Front for webgl/conn19.21]. 16:40:19 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'navigate' on TabTarget:[object XULElement]. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'will-navigate' on TabTarget:[object XULElement]. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'ShaderEditor:ProgramsAdded' on [object ChromeWindow]. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'ShaderEditor:SourcesShown' on [object ChromeWindow]. 16:40:20 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The tool's content should not be hidden. 16:40:20 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The shaders list contains one entry after navigating back. 16:40:20 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The shaders list has a correct selection after navigating back. 16:40:20 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The vertex shader editor contains the correct text. - Got 100, expected 170 16:40:20 INFO - Stack trace: 16:40:20 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 705 16:40:20 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js :: ifWebGLSupported :: line 35 16:40:20 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 233 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 767 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 531 16:40:20 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 16:40:20 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The fragment shader editor contains the correct text. - Got 89, expected 97 16:40:20 INFO - Stack trace: 16:40:20 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 705 16:40:20 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js :: ifWebGLSupported :: line 37 16:40:20 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 233 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 767 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 531 16:40:20 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'will-navigate' on TabTarget:[object XULElement]. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'ShaderEditor:ProgramsAdded' on [object ChromeWindow]. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'ShaderEditor:SourcesShown' on [object ChromeWindow]. 16:40:20 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The tool's content should not be hidden. 16:40:20 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The shaders list contains two entries after navigating forward. 16:40:20 INFO - TEST-PASS | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The shaders list has a correct selection after navigating forward. 16:40:20 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The vertex shader editor contains the correct text. - Got 170, expected 100 16:40:20 INFO - Stack trace: 16:40:20 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 705 16:40:20 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js :: ifWebGLSupported :: line 51 16:40:20 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 233 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 767 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 531 16:40:20 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 16:40:20 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | The fragment shader editor contains the correct text. - Got 97, expected 89 16:40:20 INFO - Stack trace: 16:40:20 INFO - JS frame :: chrome://mochikit/content/browser-test.js :: test_is :: line 705 16:40:20 INFO - JS frame :: chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js :: ifWebGLSupported :: line 53 16:40:20 INFO - JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 233 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 767 16:40:20 INFO - JS frame :: resource://gre/modules/Promise.jsm :: <TOP_LEVEL> :: line 531 16:40:20 INFO - native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Destroying the specified shader editor. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Waiting for event: 'destroyed' on [object Object]. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Removing tab. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Tab removed and finished closing. 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | finish() was called, cleaning up... 16:40:20 INFO - TEST-INFO | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | Forcing GC after shadereditor test. 16:40:20 INFO - TEST-INFO | MEMORY STAT vsize after test: 685817856 16:40:20 INFO - TEST-INFO | MEMORY STAT vsizeMaxContiguous after test: 504102912 16:40:20 INFO - TEST-INFO | MEMORY STAT residentFast after test: 427081728 16:40:20 INFO - TEST-INFO | MEMORY STAT heapAllocated after test: 137914350 16:40:20 INFO - INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/shadereditor/test/browser_se_bfcache.js | finished in 1512ms
It looks like this started happening after bug 940541. This is very important -- it means that shaders' source code is mixed up in the frontend. Thus, what an editor shows you is different code than it should be. Benvie, can you please take a look at this?
Flags: needinfo?(bbenvie)
Priority: -- → P2
Yeah, this was almost certainly caused by bug 940541. I'll look into it.
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Flags: needinfo?(bbenvie)
Thank you!
Attached patch shadereditor-intermittent.patch (obsolete) — — Splinter Review
Interestingly, the attached patch turns this intermittent permaorange. Hopefully this can help with figuring out the problem quicker.
Attached patch shadereditor-intermittent.patch (obsolete) — — Splinter Review
This patch fixes it but I'm not quite sure why. Victor, does this patch make any sense to you?
Attachment #8344950 - Attachment is obsolete: true
Attachment #8347470 - Flags: feedback?(vporof)
Comment on attachment 8347470 [details] [diff] [review] shadereditor-intermittent.patch Review of attachment 8347470 [details] [diff] [review]: ----------------------------------------------------------------- This "fixes" it because you reversed what's checked. This is the opposite of what you need to do... This test makes sure the right text is shown in the right editor. By changing the values you made sure the wrong text is shown.
Attachment #8347470 - Flags: feedback?(vporof) → feedback-
Any progress Brandon? This is currently the #8 top orange on trunk.
Flags: needinfo?(bbenvie)
Was out for Christmas. I'm back working on this now.
Flags: needinfo?(bbenvie)
I think this patch will fix the intermittent. It resolved the issue locally after I modified the test to always reproduce the failure, and the try run is clean. https://tbpl.mozilla.org/?tree=Try&rev=8baf675a1d52
Attachment #8347470 - Attachment is obsolete: true
Attachment #8357223 - Flags: review?(vporof)
Comment on attachment 8357223 [details] [diff] [review] shadereditor-intermittent.patch Review of attachment 8357223 [details] [diff] [review]: ----------------------------------------------------------------- This looks reasonable. A green try run would be nice.
Attachment #8357223 - Flags: review?(vporof) → review+
..and I just saw the try run, it's green. Land away!
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/55c0b8b56600
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
Some of these are definitely after comment 248 was merged around.
Status: RESOLVED → REOPENED
Flags: needinfo?(bbenvie)
Resolution: FIXED → ---
Target Milestone: Firefox 29 → ---
Back to the drawing board.
Flags: needinfo?(bbenvie)
I'm going to unassign myself from this for now. I've spent a lot of time looking at this and I don't really feel any closer to fixing it.
Assignee: bbenvie → nobody
Ok, disabling the test for now.
Whiteboard: [leave open][test disabled]
Mass-closing inactive (2 years+) bugs on unmaintained devtools components.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 7 years ago
Resolution: --- → WONTFIX
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: