947557 - ASSERTION: DidReflow() was never called with prescripted mmultiscripts as an embellished operator

Status: RESOLVED FIXED

(Core :: MathML, defect, P4)

Description

[James Kitchener (:jkitch)]

Attachment: testcase.html

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131125215016

Steps to reproduce:

Load the attached testcase in a debug build, (in my case it was an unpatched locally compiled one)


Actual results:

ASSERTION: DidReflow() was never called: '!(childFrame->GetStateBits() & NS_FRAME_IN_REFLOW)', file layout\mathml\nsMathMLContainerFrame.cpp, line 523

(6 times)


Expected results:

There should be no assertion.

Comment 1

[James Kitchener (:jkitch)]

(To be more specific, it was a Nightly build based on yesterday's mozilla-central).

Comment 2

[James Kitchener (:jkitch)]

Attachment: patch

The issue is that the children of embellished operators are checked in debug code to ensure that DidReflow was called, yet we never actually called it for <prescripts/> frames.

(The crashtest seemed the most appropriate place to check for assertions.  It shouldn't cause any crashes).

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec333f509c08

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec333f509c08