Closed Bug 947570 Opened 11 years ago Closed 11 years ago

Intermittent browser_597071.js | application timed out after 330 seconds with no output

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox27 --- unaffected
firefox28 --- unaffected
firefox29 --- fixed
firefox30 --- fixed
firefox31 --- fixed
firefox-esr24 --- unaffected
b2g-v1.2 --- unaffected

People

(Reporter: philor, Assigned: ttaubert)

References

(Depends on 1 open bug)

Details

(Keywords: hang, intermittent-failure)

Attachments

(1 file, 1 obsolete file)

0001-Bug-947570-Disable-browser_597071.js-until-rewritten.patch
1.37 KB, patch
smacleod
: review+
Details | Diff | Splinter Review
https://tbpl.mozilla.org/php/getParsedLog.php?id=31599090&tree=Mozilla-Inbound Rev3 Fedora 12 mozilla-inbound debug test mochitest-browser-chrome on 2013-12-06 17:49:16 PST for push 61cda1f28ce4 slave: talos-r3-fed-101 ... ... ... 18:28:55 INFO - --DOMWINDOW == 22 (0xdaced6c) [pid = 2385] [serial = 6304] [outer = (nil)] [url = about:blank] 18:34:04 INFO - [Parent 2385] WARNING: 1 sort operation has occurred for the SQL statement '0xb51dca40'. See https://developer.mozilla.org/En/Storage/Warnings details.: file ../../../storage/src/mozStoragePrivateHelpers.cpp, line 109 18:39:34 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_597071.js | application timed out after 330 seconds with no output 18:39:37 INFO - SCREENSHOT: 8:39:37 WARNING - TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_597071.js | application terminated with exit code 1536 18:39:37 INFO - INFO | runtests.py | Application ran for: 0:35:12.534250
Tim, this is quickly rising in frequency. Can you please take a look?
Flags: needinfo?(ttaubert)
I can't reproduce this locally but my best guess is that the setBrowserState() call somehow and sometimes makes the test suite time out waiting for focus. The test deserves to be rewritten anyway so let's hope that fixes it.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8346510 - Flags: review?(smacleod)
Flags: needinfo?(ttaubert)
Comment on attachment 8346510 [details] [diff] [review] 0001-Bug-947570-Rewrite-browser_597071.js-to-fix-intermit.patch Review of attachment 8346510 [details] [diff] [review]: ----------------------------------------------------------------- Test looks much nicer :D. r=me with an explanation of ss.getClosedWindowCount() being guaranteed 1. ::: browser/components/sessionstore/test/browser_597071.js @@ +31,4 @@ > > + // Closed the window and check the closed window count. > + yield promiseWindowClosed(win); > + is(ss.getClosedWindowCount(), 1, "correct closed window count"); Why did you switch this to only check that there is "1" closed window, instead of how the previous test checked for an increase of one? Was the previous test just being over cautious? Can you explain to me how this is guaranteed to be only 1, please?
Attachment #8346510 - Flags: review?(smacleod) → review+
(In reply to Steven MacLeod [:smacleod] from comment #26) > Why did you switch this to only check that there is "1" closed window, > instead of how the previous test checked for an increase of one? Was the > previous test just being over cautious? Can you explain to me how this is > guaranteed to be only 1, please? Sure. The first thing the new test does is clean the list of closed windows. Thus after closing one window we can assume that the list has a length of 1. The old test didn't clear the list of closed windows but instead increased the max_undo_windows preference by 1 and then checked that the count increased by one. That seemed reaaaally hackish to me.
https://hg.mozilla.org/mozilla-central/rev/e94b1d70cec1
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: ttaubert → nobody
I think the frequency is that high even with the old cache... unblocking!
No longer blocks: cache2tests
Depends on: 995916
Assignee: nobody → ttaubert
Attachment #8346510 - Attachment is obsolete: true
Attachment #8406038 - Flags: review?(smacleod)
Attachment #8406038 - Flags: review?(smacleod) → review+
status-firefox29: fixed → affected
status-firefox30: --- → affected
status-firefox31: --- → affected
Target Milestone: Firefox 29 → ---
https://hg.mozilla.org/mozilla-central/rev/473128900c70
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: