Closed
Bug 947583
Opened 11 years ago
Closed 11 years ago
"this.updateProviderURLs is not a function" when toggling "Block reported attack sites" preference
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Whiteboard: verifyme)
Attachments
(1 file)
|
1.26 KB,
patch
|
Dolske
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
When you go into the preference dialog and toggle "Block reported attack sites" an error is thrown saying that "this.updateProviderURLs is not a function". I believe that calling addObserver(this.readPrefs) doesn't pass the right scope. We should probably also have a small test that toggles the preference.
|
Assignee | |
Comment 1•11 years ago
|
||
This is broken since Fx 19 it seems and it's probably too late to get this into beta now.
status-firefox25:
--- → affected
status-firefox26:
--- → affected
status-firefox27:
--- → affected
status-firefox28:
--- → affected
tracking-firefox26:
--- → ?
tracking-firefox27:
--- → ?
tracking-firefox28:
--- → ?
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #8344149 -
Flags: review?(dolske)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8344149 -
Flags: review?(gavin.sharp)
|
||
Comment 3•11 years ago
|
||
Yes, it's not something we'd chemspill for, nor include in a dot release - we can get this uplifted if low risk to Aurora/Beta and get bake time there.
|
||
Updated•11 years ago
|
|
|
||
Comment 4•11 years ago
|
||
We do not need to track this please nominate if low risk uplift.
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8344149 [details] [diff] [review]
0001-Bug-947583-Fix-this.updateProviderURLs-is-not-a-func.patch
blech.
Attachment #8344149 -
Flags: review?(gavin.sharp)
Attachment #8344149 -
Flags: review?(dolske)
Attachment #8344149 -
Flags: review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Assignee: nobody → ttaubert
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
|
|
Assignee | |
Comment 8•11 years ago
|
||
Comment on attachment 8344149 [details] [diff] [review]
0001-Bug-947583-Fix-this.updateProviderURLs-is-not-a-func.patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 778608
User impact if declined: Changes to "Block reported attack sites" and "Block reported web forgeries" checkboxes in the pref dialog won't take effect until a browser restart.
Testing completed (on m-c, etc.):
Risk to taking this patch (and alternatives if risky): Very low-risk, one line patch.
String or IDL/UUID changes made by this patch: None.
Attachment #8344149 -
Flags: approval-mozilla-beta?
Attachment #8344149 -
Flags: approval-mozilla-aurora?
|
|
||
Updated•11 years ago
|
Attachment #8344149 -
Flags: approval-mozilla-beta?
Attachment #8344149 -
Flags: approval-mozilla-beta+
Attachment #8344149 -
Flags: approval-mozilla-aurora?
Attachment #8344149 -
Flags: approval-mozilla-aurora+
|
|
Assignee | |
Comment 9•11 years ago
|
||
|
||
Updated•11 years ago
|
|
|
||
Comment 10•11 years ago
|
||
Tim, does this have or need tests?
Flags: needinfo?(ttaubert)
Flags: in-testsuite?
|
|
Assignee | |
Comment 11•11 years ago
|
||
No, this doesn't have a test. It could have one though.
Flags: needinfo?(ttaubert)
|
||
Updated•11 years ago
|
Whiteboard: verifyme
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•