Closed
Bug 947585
Opened 11 years ago
Closed 10 years ago
[B2G][FOTA] Update will not stop when available space is not enough
Categories
(Firefox OS Graveyard :: General, defect)
Tracking
(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed)
People
(Reporter: seinlin, Assigned: seinlin)
References
Details
Attachments
(1 file, 2 obsolete files)
|
2.35 KB,
patch
|
marshall
:
review+
|
Details | Diff | Splinter Review |
In FOTA update, update service will check available space again after update.mar is downloaded and before apply it to update.zip. When available space check failed the service didn't stop and cause segment fault and this will result a strange behaviour.
|
Assignee | |
Comment 1•11 years ago
|
||
Hi Robert, Can you kindly help me have a look to this patch? When ds->Get return NS_ERROR_FAILURE, b2g update service should stop to avoid error. Now the update service will continue in case of NS_ERROR_FAILURE and got segment fault. Return the result can prevent this error.
Attachment #8344486 -
Flags: feedback?(robert.bugzilla)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8344486 [details] [diff] [review] bug-947585-fix.patch Brian, could you take a look at this? Thanks!
Attachment #8344486 -
Flags: feedback?(robert.bugzilla) → feedback?(netzen)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8344486 [details] [diff] [review] bug-947585-fix.patch Review of attachment 8344486 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine to me, although I'd like a final review from someone on GONK backend since I don't have the setup to be able to try it.
Attachment #8344486 -
Flags: review?(marshall)
Attachment #8344486 -
Flags: feedback?(netzen)
Attachment #8344486 -
Flags: feedback+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8344486 [details] [diff] [review] bug-947585-fix.patch Review of attachment 8344486 [details] [diff] [review]: ----------------------------------------------------------------- Seems reasonable to me
Attachment #8344486 -
Flags: review?(marshall) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Try server result: https://tbpl.mozilla.org/?tree=Try&rev=dd642d5aa4a8 https://tbpl.mozilla.org/?tree=Try&rev=64dc712dc56d
|
|
Assignee | |
Comment 6•11 years ago
|
||
Add reviewer's name.
|
|
Assignee | |
Comment 7•11 years ago
|
||
Correct the error hit in try server.
Attachment #8346314 -
Attachment is obsolete: true
Attachment #8346479 -
Flags: review?(marshall)
|
|
Assignee | |
Comment 8•11 years ago
|
||
New try server result: https://tbpl.mozilla.org/?tree=Try&rev=e9c2e5ed2cce
|
|
||
Updated•11 years ago
|
Attachment #8346479 -
Flags: review?(marshall) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
This bug blocks bug 931740. So I think it should also block 1.3.
blocking-b2g: --- → 1.3?
Flags: needinfo?(jsmith)
|
||
Updated•10 years ago
|
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(jsmith)
|
|
Assignee | |
Updated•10 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 10•10 years ago
|
||
Unit test try result: https://tbpl.mozilla.org/?tree=Try&rev=cf9b11af060c
|
||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/e96fa95f3e21
Keywords: checkin-needed
|
|
||
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e96fa95f3e21
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
|
|
||
Comment 13•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/2e8a7007ceec
status-b2g-v1.3:
--- → fixed
status-firefox27:
--- → wontfix
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•