Closed Bug 947585 Opened 11 years ago Closed 11 years ago

[B2G][FOTA] Update will not stop when available space is not enough

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C2/1.4 S2(17jan)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed

People

(Reporter: seinlin, Assigned: seinlin)

References

Details

Attachments

(1 file, 2 obsolete files)

bug-947585-fix-2.patch
2.35 KB, patch
marshall
: review+
Details | Diff | Splinter Review
In FOTA update, update service will check available space again after update.mar is downloaded and before apply it to update.zip. When available space check failed the service didn't stop and cause segment fault and this will result a strange behaviour.
Blocks: 931740
Attached patch bug-947585-fix.patch (obsolete) — — Splinter Review
Hi Robert, Can you kindly help me have a look to this patch? When ds->Get return NS_ERROR_FAILURE, b2g update service should stop to avoid error. Now the update service will continue in case of NS_ERROR_FAILURE and got segment fault. Return the result can prevent this error.
Attachment #8344486 - Flags: feedback?(robert.bugzilla)
Comment on attachment 8344486 [details] [diff] [review] bug-947585-fix.patch Brian, could you take a look at this? Thanks!
Attachment #8344486 - Flags: feedback?(robert.bugzilla) → feedback?(netzen)
Comment on attachment 8344486 [details] [diff] [review] bug-947585-fix.patch Review of attachment 8344486 [details] [diff] [review]: ----------------------------------------------------------------- This seems fine to me, although I'd like a final review from someone on GONK backend since I don't have the setup to be able to try it.
Attachment #8344486 - Flags: review?(marshall)
Attachment #8344486 - Flags: feedback?(netzen)
Attachment #8344486 - Flags: feedback+
Comment on attachment 8344486 [details] [diff] [review] bug-947585-fix.patch Review of attachment 8344486 [details] [diff] [review]: ----------------------------------------------------------------- Seems reasonable to me
Attachment #8344486 - Flags: review?(marshall) → review+
Attached patch bug-947585-fix.patch (obsolete) — — Splinter Review
Add reviewer's name.
Assignee: nobody → kli
Attachment #8344486 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Correct the error hit in try server.
Attachment #8346314 - Attachment is obsolete: true
Attachment #8346479 - Flags: review?(marshall)
Attachment #8346479 - Flags: review?(marshall) → review+
Blocks: 950534
This bug blocks bug 931740. So I think it should also block 1.3.
blocking-b2g: --- → 1.3?
Flags: needinfo?(jsmith)
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(jsmith)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e96fa95f3e21
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: