Spelling error in string in StringHelper class

RESOLVED FIXED in Firefox 29

Status

()

--
minor
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: Sobering, Assigned: Sobering)

Tracking

unspecified
Firefox 29
All
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 8344193 [details] [diff] [review]
fixSpellingError.patch

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20131206030202

Steps to reproduce:

I noticed that the word "remember" in the "Remember password" string in the StringHelper class was spelled incorrectly. I imagine this could frustrate somebody trying to use that string. Patch attached.
(Assignee)

Updated

5 years ago
Severity: normal → minor
OS: Mac OS X → Android
Hardware: x86 → All
(Assignee)

Comment 1

5 years ago
This is also the first time I reported something so please let me know if I can improve anything.

Updated

5 years ago
Attachment #8344193 - Attachment is patch: true
Attachment #8344193 - Attachment mime type: text/x-patch → text/plain
Attachment #8344193 - Flags: review?(michael.l.comella)

Updated

5 years ago
Assignee: nobody → ss
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment on attachment 8344193 [details] [diff] [review]
fixSpellingError.patch

Review of attachment 8344193 [details] [diff] [review]:
-----------------------------------------------------------------

Nice find! patch lgtm.

(In reply to Stefan :Sobering from comment #1)
> This is also the first time I reported something so please let me know if I
> can improve anything.

As Aaron did with the "Attachment is patch: true" change, when you attach patches, you want to make sure that the "patch" checkbox is marked. Also, if your patch is ready for review, feel free to add a reviewer by their email address (this is usually searchable by IRC nick by starting with a colon, i.e. ":mcomella" will autocomplete my email). The best reviewer will usually be the person with the most surrounding lines in `hg blame <filename>` and if not, they'll pass it off to the appropriate person. Alternatively, feel free to ask on IRC who might be appropriate to review the code.

Otherwise, all good! Thanks for you help!
Attachment #8344193 - Flags: review?(michael.l.comella) → review+
Stefan, once your patch is reviewed, you should add the "checkin-needed" keyword to get your patch checked into the source tree. I'll let you do that for practice now!
Status: NEW → ASSIGNED
(Assignee)

Comment 4

5 years ago
Thanks for letting me know, done.
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/d750b0477a83
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d750b0477a83
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 29
You need to log in before you can comment on or make changes to this bug.