Closed
Bug 947636
Opened 11 years ago
Closed 11 years ago
Servo build's backup-rust step breaks on first-time slaves
Categories
(Release Engineering :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jdm, Assigned: jdm)
Details
Attachments
(1 file)
|
2.15 KB,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
We're seeing the rust-backup step failing on a slave because config.mk is missing. http://servo-buildbot.pub.build.mozilla.org/builders/linux/builds/685/steps/shell/logs/stdio looks like it's performing a build for the first time in a clean environment, so we need to write the rules to check for the presence of an objdir (which implies a config.mk that is present) instead of just a srcdir.
|
Assignee | |
Updated•11 years ago
|
Summary: Servo build's rust-backup step breaks on first-time slaves → Servo build's backup-rust step breaks on first-time slaves
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8344224 -
Flags: review?(bhearsum)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → josh
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8344224 [details] [diff] [review]
Avoid backing up non-existent Rust builds.
Review of attachment 8344224 [details] [diff] [review]:
-----------------------------------------------------------------
Did Makefile(.backup) always depend on config.mk or this a relatively recent thing?
Land this at your convenience, I'll merge it to production sometime today.
Attachment #8344224 -
Flags: review?(bhearsum) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
||
Comment 4•11 years ago
|
||
In production.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•