947652 - Make OS_TARGET=WIN95 the default on Windows

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: default-OS_TARGET_WIN95-on-Windows.patch

Whenever I tell somebody how to build NSS, I have to give them two sets of instructions: "make nss_build_all", or "OS_TARGET=WIN95 make nss_build_all" on Windows. Also, we've seen people getting confused about OS_TARGET=WINNT vs OS_TARGET=WIN95 and also, AFAICT, we consider OS_TARGET=WINNT deprecated or close to deprecated.

This patch makes OS_TARGET=WIN95 when OS_ARCH=WINNT when OS_TARGET isn't explicitly defined.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Can we just make NSS's build system smart enough to figure out which system it's on in the absence of OS_TARGET? (Or is that basically what this does?)

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to David Keeler (:keeler) from comment #1)
> Can we just make NSS's build system smart enough to figure out which system
> it's on in the absence of OS_TARGET? (Or is that basically what this does?)

This is what the patch does. Windows is an exception because the default, WINNT, is not the one most people want.

Comment 3

[:Cykesiopka]

Is this a subset or dupe of Bug 814982?

Comment 4

[Wan-Teh Chang]

Comment on attachment 8344241 [details] [diff] [review]
default-OS_TARGET_WIN95-on-Windows.patch

Review of attachment 8344241 [details] [diff] [review]:
-----------------------------------------------------------------

r=wtc.

::: coreconf/arch.mk
@@ +150,5 @@
>  #
>  
>  #
>  # The following hack allows one to build on a WIN95 machine (as if
>  # s/he were cross-compiling on a WINNT host for a WIN95 target).

We should also remove this block of code. We don't build on
Win9x machines any more. I can write a patch.

Comment 5

[Wan-Teh Chang]

Attachment: Remove support for building on Win9x machines

Comment 6

[Wan-Teh Chang]

Comment on attachment 8344241 [details] [diff] [review]
default-OS_TARGET_WIN95-on-Windows.patch

Review of attachment 8344241 [details] [diff] [review]:
-----------------------------------------------------------------

::: coreconf/arch.mk
@@ +230,5 @@
>  	endif
>      endif
>  endif
>  #
> +# If uname -s returns "MINGW32_NT-*", we assume that we are using

A few lines above, there is a comment that says
  # If uname -s returns "MINGW32_NT-5.1", we assume that we are using

It should be fixed in the same way.

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8344241 [details] [diff] [review]
default-OS_TARGET_WIN95-on-Windows.patch

Review of attachment 8344241 [details] [diff] [review]:
-----------------------------------------------------------------

::: coreconf/arch.mk
@@ +230,5 @@
>  	endif
>      endif
>  endif
>  #
> +# If uname -s returns "MINGW32_NT-*", we assume that we are using

I guess you meant this:

# If uname -s returns "CYGWIN_NT-*", we assume that we are using
# the uname.exe in the Cygwin tools.

I made the change.

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 1: Make OS_TARGET=WIN95 the default on Windows

Comment 9

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Part 2: Remove support for building on Win9x machines

Comment 10

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

http://hg.mozilla.org/projects/nss/rev/6593411d388b
http://hg.mozilla.org/projects/nss/rev/ccaf2d1690fc

Comment 11

[Wan-Teh Chang]

Comment on attachment 8344241 [details] [diff] [review]
default-OS_TARGET_WIN95-on-Windows.patch

Review of attachment 8344241 [details] [diff] [review]:
-----------------------------------------------------------------

::: coreconf/arch.mk
@@ +230,5 @@
>  	endif
>      endif
>  endif
>  #
> +# If uname -s returns "MINGW32_NT-*", we assume that we are using

Yes, you are right. Sorry about the copy-and-paste error.

Comment 12

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Backed out for Windows test failures:
http://hg.mozilla.org/projects/nss/rev/299a8e8c904a
http://hg.mozilla.org/projects/nss/rev/49360b638350

Comment 13

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Log of build failure #1: 3-win7-x64-DBG.txt

Comment 14

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Log of build failure #2: 3-winxp-x64-DBG.txt

Comment 15

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Log of build failure #3: 3-winxp-x64-OPT.txt

Comment 16

[Wan-Teh Chang]

Comment on attachment 8347100 [details] [diff] [review]
Part 2: Remove support for building on Win9x machines

This patch doesn't need to be backed out. I checked it in again:
https://hg.mozilla.org/projects/nss/rev/89704a8628e9

Comment 17

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8347099 [details] [diff] [review]
Part 1: Make OS_TARGET=WIN95 the default on Windows

(In reply to Wan-Teh Chang from comment #16)
> Comment on attachment 8347100 [details] [diff] [review]
> Part 2: Remove support for building on Win9x machines
> 
> This patch doesn't need to be backed out. I checked it in again:
> https://hg.mozilla.org/projects/nss/rev/89704a8628e9

Neither patch needed to be backed out. Since you checked in the second one again, I just checked in the first one, so that the two patches for this bug are not split between two different releases:

http://hg.mozilla.org/projects/nss/rev/5f4ba3533468