947743 - Restore junkcol.png

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: General, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: restore_junkcol.patch

Bug 633937 falsely removed junkcol.png from the Classic theme's jar.mn, probably due to ewong misunderstanding comment 17 ("Also remove the old icons!"). The file is still referenced in threadPane.css.

The patch is simple enough for taking on branches, too. Since it will probably miss 2.23b2 (which AFAIU is already tagged and being built), please consider it also taking it for 2.23 final despite that then being different to the final beta.

Comment 1

[Ian Neal]

Comment on attachment 8344384 [details] [diff] [review]
restore_junkcol.patch

a=me for when you need them

Comment 2

[Ian Neal]

Comment on attachment 8344384 [details] [diff] [review]
restore_junkcol.patch

Shouldn't we be removing the junkBar.png from the repos?

Comment 3

[Jens Hatlak (:InvisibleSmiley)]

(In reply to Ian Neal from comment #2)
> Shouldn't we be removing the junkBar.png from the repos?

Maybe, but better not in a bug that tries to fix a regression ASAP? I don't want to introduce a new one, was not involved in bug 633937, and don't want our users to wait another six weeks for this fix when it gets delayed by further discussions.

That said, if reviewers want me to remove it here, I'll of course do.

Comment 4

[[e-mail]]

Comment on attachment 8344384 [details] [diff] [review]
restore_junkcol.patch

[Approval Request Comment]
Regression caused by (bug #): 633937
User impact if declined: Can't view junk status in Classic theme
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: None

Comment 5

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 8344384 [details] [diff] [review]
restore_junkcol.patch

https://hg.mozilla.org/comm-central/rev/78bb119743cf
https://hg.mozilla.org/releases/comm-aurora/rev/7ef5c8431e22
https://hg.mozilla.org/releases/comm-beta/rev/4071d6f3f42d

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

Whether this fix will actually be included in SM 2.23 depends on tagging, so I'll leave a note in bug 947790.

Comment 7

[Philip Chee]

(In reply to Ian Neal from comment #2)
> Comment on attachment 8344384 [details] [diff] [review]
> restore_junkcol.patch
> 
> Shouldn't we be removing the junkBar.png from the repos?
File another bug for this?