Last Comment Bug 947963 - Invalidate compilation after OOM in CodeGenerator::link
: Invalidate compilation after OOM in CodeGenerator::link
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine: JIT (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: mozilla29
Assigned To: Brian Hackett (:bhackett)
:
: Hannes Verschore [:h4writer]
Mentors:
Depends on:
Blocks: 912928
  Show dependency treegraph
 
Reported: 2013-12-09 08:29 PST by Brian Hackett (:bhackett)
Modified: 2013-12-09 20:43 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (2.79 KB, patch)
2013-12-09 08:29 PST, Brian Hackett (:bhackett)
jdemooij: review+
Details | Diff | Splinter Review

Description User image Brian Hackett (:bhackett) 2013-12-09 08:29:30 PST
Created attachment 8344680 [details] [diff] [review]
patch

If we don't invalidate the compilation after failures at these spots, we can get into a later state where the compiler output thinks it is valid even though Ion compilation for the script is disabled.
Comment 1 User image Brian Hackett (:bhackett) 2013-12-09 11:59:41 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/90d64e42de1d
Comment 2 User image Wes Kocher (:KWierso) 2013-12-09 20:43:54 PST
https://hg.mozilla.org/mozilla-central/rev/90d64e42de1d

Note You need to log in before you can comment on or make changes to this bug.