Closed
Bug 947981
Opened 11 years ago
Closed 11 years ago
broken --with-system-icu build
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox28- affected, firefox29- affected)
RESOLVED
FIXED
mozilla29
People
(Reporter: wingo, Assigned: m_kato)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.27 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce: on inbound cd js/src autoconf2.13 mkdir +release cd +release ../configure --with-system-nspr --with-system-icu make Results: most things appear to build, and then: make[1]: Leaving directory `/home/wingo/src/mozilla-central/js/src/+release' make libs libjs_static.a make[1]: Entering directory `/home/wingo/src/mozilla-central/js/src/+release' rm -f libjs_static.a libjs_static.a.desc /home/wingo/src/mozilla-central/js/src/+release/_virtualenv/bin/python ../config/expandlibs_exec.py --depend .deps/libjs_static.a.pp --target libjs_static.a --extract -- ar crs libjs_static.a Compression.o Decimal.o Parser.o jsarray.o jsatom.o jsmath.o jsutil.o ExecutableAllocatorPosix.o OSAllocatorPosix.o ARMAssembler.o MacroAssemblerARM.o MacroAssemblerX86Common.o YarrJIT.o pm_linux.o Unified_cpp_0.o Unified_cpp_1.o Unified_cpp_2.o Unified_cpp_3.o Unified_cpp_4.o Unified_cpp_5.o Unified_cpp_6.o Unified_cpp_7.o Unified_cpp_8.o Unified_cpp_9.o Unified_cpp_10.o Unified_cpp_11.o -licui18n -licuuc -licudata Executing: ar crs libjs_static.a Compression.o Decimal.o Parser.o jsarray.o jsatom.o jsmath.o jsutil.o ExecutableAllocatorPosix.o OSAllocatorPosix.o ARMAssembler.o MacroAssemblerARM.o MacroAssemblerX86Common.o YarrJIT.o pm_linux.o Unified_cpp_0.o Unified_cpp_1.o Unified_cpp_2.o Unified_cpp_3.o Unified_cpp_4.o Unified_cpp_5.o Unified_cpp_6.o Unified_cpp_7.o Unified_cpp_8.o Unified_cpp_9.o Unified_cpp_10.o Unified_cpp_11.o -licui18n -licuuc -licudata ar: invalid option -- '1' Usage: ar [emulation options] [-]{dmpqrstx}[abcDfilMNoPsSTuvV] [--plugin <name>] [member-name] [count] archive-file file... ar -M [<mri-script] commands: d - delete file(s) from the archive m[ab] - move file(s) in the archive p - print file(s) found in the archive q[f] - quick append file(s) to the archive r[ab][f][u] - replace existing or insert new file(s) into the archive s - act as ranlib t - display contents of archive x[o] - extract file(s) from the archive command specific modifiers: [a] - put file(s) after [member-name] [b] - put file(s) before [member-name] (same as [i]) [D] - use zero for timestamps and uids/gids [U] - use actual timestamps and uids/gids (default) [N] - use instance [count] of name [f] - truncate inserted file names [P] - use full path names when matching [o] - preserve original dates [u] - only replace files that are newer than current archive contents generic modifiers: [c] - do not warn if the library had to be created [s] - create an archive index (cf. ranlib) [S] - do not build a symbol table [T] - make a thin archive [v] - be verbose [V] - display the version number @<file> - read options from <file> --target=BFDNAME - specify the target object format as BFDNAME optional: --plugin <p> - load the specified plugin emulation options: No emulation specific options ar: supported targets: elf64-x86-64 elf32-i386 elf32-x86-64 a.out-i386-linux pei-i386 pei-x86-64 elf64-l1om elf64-k1om elf64-little elf64-big elf32-little elf32-big pe-x86-64 pe-i386 plugin srec symbolsrec verilog tekhex binary ihex make[1]: *** [libjs_static.a] Error 1 make[1]: Leaving directory `/home/wingo/src/mozilla-central/js/src/+release' make: *** [default] Error 2
Assignee | ||
Comment 1•11 years ago
|
||
regression by bug 915735.
Updated•11 years ago
|
status-firefox28:
--- → affected
status-firefox29:
--- → affected
tracking-firefox28:
--- → ?
tracking-firefox29:
--- → ?
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8346497 [details] [diff] [review] fix This is a regression by bug 915735. We need respect MOZ_NATIVE_ICU.
Attachment #8346497 -
Flags: review?(mh+mozilla)
Updated•11 years ago
|
Comment 4•11 years ago
|
||
We are not going to track this at this time. Please feel free to nominate a patch for risk evaluation.
Comment 5•11 years ago
|
||
Comment on attachment 8346497 [details] [diff] [review] fix Review of attachment 8346497 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/Makefile.in @@ +370,4 @@ > DEFINES += -DUSE_ZLIB > endif > > +ifneq (,$(MOZ_SHARED_ICU)$(MOZ_NATIVE_ICU)) One of the points of MOZ_SHARED_ICU was to avoid this kind of construct. So this just means you want to make MOZ_NATIVE_ICU mean MOZ_SHARED_ICU. Which I think should just solve the entire problem with just a change in configure.in
Attachment #8346497 -
Flags: review?(mh+mozilla) → review-
Assignee | ||
Comment 6•11 years ago
|
||
configure.in change only. (and remove unused macro)
Attachment #8346497 -
Attachment is obsolete: true
Attachment #8348585 -
Flags: review?(mh+mozilla)
Comment 7•11 years ago
|
||
Comment on attachment 8348585 [details] [diff] [review] v2 Review of attachment 8348585 [details] [diff] [review]: ----------------------------------------------------------------- ::: configure.in @@ +3914,5 @@ > if test -n "$MOZ_NATIVE_ICU"; then > PKG_CHECK_MODULES(MOZ_ICU, icu-i18n >= 50.1) > MOZ_JS_STATIC_LIBS="$MOZ_JS_STATIC_LIBS $MOZ_ICU_LIBS" > + MOZ_SHARED_ICU=1 > + AC_SUBST(MOZ_SHARED_ICU) AC_SUBST is unnecessary here, it's already in build/autoconf/icu.m4
Attachment #8348585 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/82f8fd52a774
Target Milestone: --- → mozilla29
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/82f8fd52a774
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•