948009 - Record length of time spent with customize dialog open.

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We want UITelemetry on how long the customization dialog is open for.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This can be skewed really badly if someone leaves it open and walks away from their machine. Should we only track time during mousemove events?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to Jared Wein [:jaws] from comment #1)
> This can be skewed really badly if someone leaves it open and walks away
> from their machine. Should we only track time during mousemove events?

While this is true, after talking with bwinton, we're thinking that these events are rare enough that we can cull them as outliers.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8346126 [details] [diff] [review]
Patch v1.1

Batter up!

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8346126 [details] [diff] [review]
Patch v1.1

Review of attachment 8346126 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to put "[Holly]" in the commit message.

::: browser/modules/BrowserUITelemetry.jsm
@@ +223,5 @@
>  
> +// Weakly maps browser windows to objects whose keys are relative
> +// timestamps for when some kind of session started. For example,
> +// when a customization session started. That way, when the window
> +// exists customization mode, we can determine how long the session

s/exists/exits/

@@ +452,5 @@
>  
> +  startCustomizing: function(aWindow) {
> +    this.countCustomizationEvent("start");
> +    let durationMap = WINDOW_DURATION_MAP.get(aWindow);
> +    durationMap.customization = Date.now();

Please use aWindow.performance.now() instead (here and below) as Date.now() is not guaranteed to be monotonically increasing.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Done! As usual, fantastic reviewing time.

Landed on Holly as https://hg.mozilla.org/projects/holly/rev/3f0c7e1df6d6

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8346126 [details] [diff] [review]
Patch v1.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

None. This gives BrowserUITelemetry the ability to record durations spent with the customization dialog open.


User impact if declined: 

None.


Testing completed (on m-c, etc.): 

Just manual testing.


Risk to taking this patch (and alternatives if risky): 

Very low.


String or IDL/UUID changes made by this patch:

None.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Removing Australis:P1 whiteboard tag because these already block an Australis:P1 bug, and being redundant isn't helpful.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Landed in mozilla-beta as https://hg.mozilla.org/releases/mozilla-beta/rev/ae8fdae4f2fb

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Landed in mozilla-aurora as https://hg.mozilla.org/releases/mozilla-aurora/rev/c6e54e98babe