Closed
Bug 948045
Opened 11 years ago
Closed 11 years ago
Enable device-* media queries in responsive mode for gaia
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(Not tracked)
RESOLVED
FIXED
1.3 C1/1.4 S1(20dec)
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
(Whiteboard: [c= p=1 s=2013.12.20 u=])
Attachments
(1 file)
We need this.
|
Assignee | |
Comment 1•11 years ago
|
||
Thanks for the pointers on this Alex. Could either of you guys review this? Thanks!
Attachment #8344787 -
Flags: review?(poirot.alex)
Attachment #8344787 -
Flags: review?(paul)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8344787 [details] [review] Github pull request r+, but know that "device_size_is_page_size" has limitations. For example, in Gaia, the height will be the height of the page, not the height of the screen (so in apps, this won't include the size of the status bar). I am working on a better solution for that (which will support rotation, orientation, lock and custom screen size), and this pref will be killed (but it won't happen soon).
Attachment #8344787 -
Flags: review?(paul) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8344787 -
Flags: review?(poirot.alex)
|
|
Assignee | |
Comment 3•11 years ago
|
||
That's a shame, but this is better than nothing for now. Landing in master: https://github.com/mozilla-b2g/gaia/commit/a549d67f33de8bce90ad96e0a30bcff51f79c357
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [c= p=1 s= u=] → [c= p=1 s=2013.12.20 u=]
|
||
Updated•10 years ago
|
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•