Closed Bug 948171 Opened 6 years ago Closed 6 years ago

ASan: LLVM_SYMBOLIZER isn't being defined in js/src/configure.in

Categories

(Firefox Build System :: General, defect, major)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: decoder, Assigned: decoder)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

js-asan-symbols.patch
1.08 KB, patch
ted
: review+
Details | Diff | Splinter Review 
Bug 948050 shows an unsymbolized ASan trace being emitted from the jit-tests. I quickly checked why it's not symbolizing and I think it's because js/src/configure.in is out of sync with the regular configure.in in terms of ASan. In the regular configure.in we have both

> MOZ_PATH_PROG(LLVM_SYMBOLIZER, llvm-symbolizer)

and

> AC_SUBST(LLVM_SYMBOLIZER)

to support the LLVM symbolizer for ASan traces. In js/src/configure.in, that's missing although we use LLVM_SYMBOLIZER in js/src/Makefile.in for the jit-tests. The attached patch adds the missing lines.
Attachment #8344945 - Flags: review?(ted)
Attachment #8344945 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/dd46a766c144
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.