948212 - FxAccounts.jsm: internal.signOut() is not a function

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Innocent bystander struck down during refactoring: services/fxaccounts/FxAccounts.jsm line 178 calls internal.signOut(), which does not exist.

Comment 1

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: 948212.signOut.patch

Something like this for the signOut fix.

Not ready for review yet.  There are one or two things I want to understand better about why I'm hitting this code path on sign in with a new user.

Comment 2

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Yes, this code path will always be taken if we are using the current Persona API, which fires logout after ready when there is no signed in user.  Once the SSO story for Firefox Accounts is resolved (closing bug 945363), this may change.

But for now, this fix should go in.

Comment 3

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Comment on attachment 8345013 [details] [diff] [review]
948212.signOut.patch

Hi, Mark,

This got overlooked in the FxAccounts.jsm patch: I think there needs to be an 'internal' signOut method as well as the one in the public API.

Thanks for taking a look,
j

Comment 4

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Attachment: 948212.signOut.patch

Updated checkin comment; r=markh

Comment 5

[Jed Parsons (use needinfo, please) [:jedp, :jparsons]]

Thank you, Mark, for your ever-speedy reviews!  Cheers, j

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/a5326f339aa9

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5326f339aa9