948241 - Convert plain arrays to mozilla::Array and FixedList

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: mozilla-array.patch

The attached patches convert several plain arrays to mozilla:Array, and some (pointer, size) pairs to use FixedList. This provides better bounds checking.

Comment 1

[Dan Gohman [:sunfish]]

Attachment: ds-asmjscall.patch

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 8345064 [details] [diff] [review]
ds-asmjscall.patch

I thought I already r+'d this somewhere else...

Comment 3

[Dan Gohman [:sunfish]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c39721a052f3
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e1d913c4436

Comment 4

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/7c17d67dac5b - the Android builds say https://tbpl.mozilla.org/php/getParsedLog.php?id=31720138&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=31720131&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=31720124&tree=Mozilla-Inbound

Comment 5

[Phil Ringnalda (:philor)]

And https://tbpl.mozilla.org/php/getParsedLog.php?id=31721432&tree=Mozilla-Inbound from b2g, once it finally got around to failing.

Comment 6

[Dan Gohman [:sunfish]]

Compile errors on ARM fixed, and reapplied:
https://hg.mozilla.org/integration/mozilla-inbound/rev/afbd56360969
https://hg.mozilla.org/integration/mozilla-inbound/rev/a56e3ea436a9

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afbd56360969
https://hg.mozilla.org/mozilla-central/rev/a56e3ea436a9