948268 - cant exit fullscreen programatically

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jorge]

Attachment: exit-fs-programatically.rar

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/31.0.1650.63 Safari/537.36

Steps to reproduce:

I have a page where the user can exit fullscreen with button, or the application can exit fullscreen.
The application tries to exit fullscreen by calling cancelFullscreen.
In the example attached, the app can exit fullscreen by itself after 2 seconds of entering fullscreen.


Actual results:

The application calls the fullscreen API, but it is ignored.


Expected results:

firefox should exit fullscreen when the app requests it.

Comment 1

[Masatoshi Kimura [:emk]]

According to the Fullscreen spec, exitFullscreen() doesn't check if the algorithm is allowed to show a popup.

Comment 2

[Masatoshi Kimura [:emk]]

Attachment: bug948268_exitfullscreen

Do the obvious.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: Fixup the test

I'll fold this on landing.

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8345851 [details] [diff] [review]
bug948268_exitfullscreen

Review of attachment 8345851 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is a good idea. This effect can already be achieved by removing the fullscreen element from the document; removing the fullscreen element from its document exits fullscreen.

This is also the behaviour that Chrome has, testcase: http://pearce.org.nz/f press "Toggle fullscreen" button, then "Delay cancel" button, Chrome exits fullscreen, we don't.

I would like to get more people to OK this though, so requesting feedback from Olli and Bz.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

So what happens if a web page enters and exits fullscreen in a loop?

Comment 6

[Masatoshi Kimura [:emk]]

(In reply to Olli Pettay [:smaug] from comment #5)
> So what happens if a web page enters and exits fullscreen in a loop?

It's impossible because entering fullscreen still requires the privilege.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

But if you do enterFullScreen(), exitFullScreen() in a loop.
We're handling user input so entering fullscreen should succeed.


(Just want to understand the behavior we get and what behavior we want.)

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8345851 [details] [diff] [review]
bug948268_exitfullscreen

This seems fine to me, given that it doesn't actually add new capabilities given the element-removing setup...

Comment 9

[Masatoshi Kimura [:emk]]

(In reply to Olli Pettay [:smaug] from comment #7)
> But if you do enterFullScreen(), exitFullScreen() in a loop.
> We're handling user input so entering fullscreen should succeed.
> 
> 
> (Just want to understand the behavior we get and what behavior we want.)

Currently exitFullScreen() will do the same check as enterFullScreen(). If enterFullScreen() succeeds for any reason, exitFullScreen() will also succeed. So this change will make nothing worse.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8345851 [details] [diff] [review]
bug948268_exitfullscreen

indeed

Comment 11

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/be5f5ca171f0

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/be5f5ca171f0