948356 - [SMS] When displaying message options (tap and hold on a message) and the keyboard is open...

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[José Vittone]

Attachment: sms-overlay.png

Message options must overlay the keyboard.

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Actually we can't overlay the keyboard but we can make it disappear.

This is a 1.3 issue.

Comment 2

[José Vittone]

Yes, that could be a solution.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3+ regression

Comment 4

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Note to whoever will take this bug: the solution is to focus the main dialog container in the show() method in action_menu.js, just like we do in attachment_menu.js (see [1]). The dialog needs a tabindex = -1 property (see [2]).

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/js/attachment_menu.js#L46
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/index.html#L216

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

It's not a regression, the issue happens since the message options have been implemented.

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Jul 24)]

Was implemented in bug 927783.

Comment 7

[Steve Chung [:steveck]]

Attachment: Link to github

Hi Borja, I set reviewer to you since this is related to your previous task ;)

Comment 8

[Borja Salguero [:borjasalguero]]

Comments on github! :)

Comment 9

[Steve Chung [:steveck]]

(In reply to Borja Salguero [:borjasalguero] from comment #8)
> Comments on github! :)

Julien already explained the idea clearly, applying blur and focus might have no difference to most of the users, but app accessibility will be improved from this patch becuase the correct navigator sequence(if we focus the form first).

Comment 10

[Borja Salguero [:borjasalguero]]

Comment on attachment 8349906 [details] [review]
Link to github

I thought that I have given r+ before! My fault. R+ taking into consideration the explanation given.

Comment 11

[Steve Chung [:steveck]]

Thanks!
Landed in master: 24bb4bfb0cbad51de8bc3eb014614d1f1c5940ab

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 24bb4bfb0cbad51de8bc3eb014614d1f1c5940ab to:
v1.3: d91ece211e418ce76dceadf70fd3289568182e74