948478 - Metro Firefox hangs at startup trying to show add-on update dialog

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Install/Update, defect, P2)

Description

[Matt Brubeck (:mbrubeck)]

Steps to reproduce:
Using a profile with extensions installed, run one version of Metro Firefox (e.g. 28.0a1) and then close it and run a different version (e.g. 29.0a1).  Metro Firefox will hang at the splash screen.

This happens when upgrading from one version to the next, or when switching from one channel to another.  You can also simulate it by editing the extensions.lastAppVersion pref in the metro-prefs.js file.

We suspect this is the same underlying problem as bug 945829 -- the extension manager is trying to show a dialog, which we don't support in Metro.

Comment 1

[Marco Mucci [:MarcoM]]

Hey Brian, will you be taking this during IT#21 or a future one?

Comment 2

[Brian R. Bondy [:bbondy]]

Yep I'm doing a similar fix with a hang from profile manager on startup, so I'll take it in this iteration. Confirmed p=1.

Comment 3

[Brian R. Bondy [:bbondy]]

Attachment: rev1

Found this handy pref :)
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/XPIProvider.jsm#2035

Comment 4

[Robert Strube]

Hi Folks,

I can confirm the same behavior after upgrading from 28.0a1 to 29.0a1.  Metro Firefox now hangs whenever I try to open it.  The desktop version opens and displays a dialog from the extension manager.

At this point my solution was to delete my local profile completely, and relaunch firefox in desktop mode. This creates a brand new empty profile.  I then resynced all of my bookmarks and extensions.

I hope this helps others that are having issues with Metro FF hanging after the move to nightly 29.0a1.

Incidentally the same issue affects Aurora 28.0a2 if you have a profile created with nightly 28.0a1.

Comment 5

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/fx-team/rev/c0c6d55b7cfb

Comment 6

[Brian R. Bondy [:bbondy]]

Will request uplift to Aurora after it lands on m-c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0c6d55b7cfb

Comment 8

[Brian R. Bondy [:bbondy]]

Comment on attachment 8345486 [details] [diff] [review]
rev1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 924860
User impact if declined: Addon update check can hang metrofx startup
Testing completed (on m-c, etc.): It's been on m-c for a couple days.
Risk to taking this patch (and alternatives if risky): very low, affects metro only
String or IDL/UUID changes made by this patch: none

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/29ce4b1f69d4

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

While verifying this using a profile containing several extensions installed I've encountered the following:

- Upgrading from one version to the next one seems to work fine.

- When changing the Metro Firefox version (from 28.0a1 to 29.0a1 or from Nightly to Aurora), the desktop mode is shown everytime, even if last used mode was metro (add-on update dialog shown).

- If using Nightly in metro mode, closed and switched to Aurora, when I've selected to launch in metro interface - "Keep using Nightly" appears in the selection pop-up instead of being able to choose Aurora (and vice-versa) but the metro interface is opened correctly, despite the pop-up selection.

Comment 11

[u279076]

(In reply to Cornel Ionce [QA] from comment #10)
> While verifying this using a profile containing several extensions installed
> I've encountered the following

Brian, are any of these issues of concern?

Comment 12

[Brian R. Bondy [:bbondy]]

The multi install related issues are most likely already posted, but if there is an issue outside of multi install please post a new bug.  That means that if you can reproduce a problem with only having Nightly installed, then please post. (Or only having Aurora install, but not having both installed).

Comment 13

[Cornel Ionce [:noni] [Hubs QA]]

Thank you Brian.
There are no issues with a single Firefox version installed. Tested with Nightly and Aurora on Windows 8.1 32bit and 64bit. The browser will not hang after the update (from metro interface).
Marking as verified.