948493 - [SMS] message input box is really laggy when receiving focus

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::SMS, defect, P2)

Description

[Dave Huseby [:huseby]]

Test device: Geeksphone Keon FxOS v1.2 stable

In pretty much all cases (i.e. right after launching app, right after switching to the app, right after receiving a text message) when I tap on the message input box to type a message, I have to wait for 3-5 seconds before my taps are registered and the focus switches to the input box.

This is *really* annoying for somebody like me who does a lot of back-and-forth texting with people.

This needs to be verified on newer versions and fixed or closed as invalid if it doesn't happen in 1.3 or master.

Comment 1

[Julien Wajsberg [:julienw]]

If you have a big SMS database, then it's pretty much known. We actually made some improvements in 1.3 but we're not there yet.

Bug 903763 is one of the main culprits if you are in a huge conversation when answering a message.
Bug 859730 is one of the main culprits if you have a big mailbox with lots of conversations.

We're doing some refactorings in small pieces, and I expect we'll be able to finally fix those bugs correctly in 1.4.

I agree with you: as a dogfood user, this is one of the most annoying thing in the daytoday use of the SMS app.

I'll dupe to bug 903763 because I feel this is a bug that could be fixed right here right now if somebody wanted to have a look ;)

Comment 2

[Julien Wajsberg [:julienw]]

Reopening per bug 903763 comment 5.

Maybe the issue is more about getting the click event than a perf issue. For example, I know we have issues with the event fluffing in 1.2 and that it will be disabled, but maybe it's not yet.

I'll flash a 1.2 build tomorrow and see if I can reproduce.

Comment 3

[Julien Wajsberg [:julienw]]

So, I just flashed the latest 1.2 from geeksphone on a peak, and I really can't reproduce this. Maybe my expectations are lower than for oyu but I don't see such a lag or error.

Note that the event fluffing has been disabled on 1.2 on December 2nd, so is it possible you had a build from before this?

Could you please try the newest v1.2 build?

Comment 4

[Dave Huseby [:huseby]]

Attachment: latest v1.2 from geeksphone

Notice how I touch the input box multiple times, over and over again and it takes a good 5-7 seconds before the keyboard pops up.  Then after I send the first SMS, I touch the input box again multiple times and it takes 3-5 seconds for the keyboard to pop up again.

Comment 5

[Dave Huseby [:huseby]]

Attachment: latest v1.3 from geeksphone

As you can see in this one, with v1.3, the keyboard pops up *MUCH* faster.  It's still around 1 second, but I can live with that.  It was the 5-7 seconds with v1.3 that got in my way of efficient use.

Comment 6

[Dave Huseby [:huseby]]

Attachment: latest peak v1.2 from geekspone

This is a video of the latest v1.2 on a peak.  The response is much better than v1.2 on the keon, but that's probably because of the faster CPU.

Comment 7

[Dave Huseby [:huseby]]

Attachment: latest peak v1.3 from geeksphone

This is a video of v1.3 on a peak.  The response is the best of all of the tests I've done.  The faster CPU and the better event handling vastly improved performance.

Comment 8

[Dave Huseby [:huseby]]

I've added videos showing some tests I ran with v1.2 and v1.3 on both a Keon and a Peak.  As you can see, v1.2 on a Keon is really, really bad.  With v1.3 on the Keon, things are much better.  On the Peak, the v1.2 wasn't really bad, it's certainly tolerable.  With v1.3, as with v1.3 on the Keon, things are even faster.

I think the new event handling stuff in v1.3 has fixed this issue.  I'm OK with closing this unless we think we still need to fix v1.2.  Maybe backport the event fluffing from v1.3 to v1.2?

Comment 9

[Julien Wajsberg [:julienw]]

I'm glad this is better on 1.3. I know the keyboard handling has been completely refactored in 1.3 too.

I still wonder what's happening on 1.2 though. Do you see such lags in other apps as well (eg: browser, email...) ?

I have a keon with a broken screen so I'll try to flash something on it, just to see this myself. It's probably too late to do anything on 1.2 though, but not knowing the reason for this is making me mad ;)

Keeping the needinfo then.

Comment 10

[Julien Wajsberg [:julienw]]

Attachment: Video of my keon under 1.2

So, I took my keon, I flashed the latest v1.2 build from geeksphone without keeping my data, I flashed a reference workload ("make reference-workload-medium" from the gaia directory) and I tried what you tried (albeit with my own finger ;) ) and, well, it's not _fast_, but I get something happening in about 1 second.

(sorry for the quality of the video, I used a Peak to take it ;) )

Therefore I really wonder what's happening for you. Do you think we should investigate more, or that we should close this bug?

Comment 11

[Mike Lee [:mlee]]

Dave, need you to reply on this.

Comment 12

[Dave Huseby [:huseby]]

I can't get the make reference-workload-medium to work with any of my Keon's.  I tried v1.2 branch of gaia, I tried doing a BRANCH=v1.2 ./config.sh keon in my B2G clone and that is broken now.  I'll get around the roadblocks and take a closer look at this tomorrow.

Comment 13

[Julien Wajsberg [:julienw]]

strangely, it works fine for me :(

What do you mean that you can't get it to work? Does it load? what happens when you launch the app?

Sometimes I had to remove the existing DB by hand before flashing the workload, I don't know the reaosn, but maybe that's your issue.

Also note that the DB on the current master are the same one that in 1.1, 1.2 and 1.3, there were not updated since then.

Comment 14

[Dave Huseby [:huseby]]

I figured it out.  You can't have the USB storage enabled.  If that's enabled, the copy commands in the make reference-workload-medium don't work.

Comment 15

[Julien Wajsberg [:julienw]]

Makes sense, thanks for sharing.

Comment 16

[Dave Huseby [:huseby]]

Attachment: Seems to be fixed in v1.2 as well. Bug_948493.webm

Comment 17

[Dave Huseby [:huseby]]

So I tested it with the latest v1.2 from geeksphone and used the 'make reference-workload-medium' to add some content.  It seems to be fixed as you can see in the video.  I'm seeing a much more responsive keyboard pop-up.  I would recommend we close this bug.

Comment 18

[Julien Wajsberg [:julienw]]

It's not possible to do changes to 1.2 anyway so...

Thanks for testing! Let's close this :)