Closed
Bug 948512
Opened 12 years ago
Closed 12 years ago
Autophone - specify device specific tests
Categories
(Testing Graveyard :: Autophone, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
Details
Attachments
(2 files)
|
2.62 KB,
patch
|
mcote
:
review+
|
Details | Diff | Splinter Review |
|
2.50 KB,
patch
|
Details | Diff | Splinter Review |
When running multiple tests on multiple devices, it is useful to be able to restrict some devices to running only a specific set of tests.
The easiest short term solution is to add an additional property to the test manifest which specifies which devices are to run the specific test as a space delimited list. If devices = all or if no devices property is specified, then all devices will run the test.
Attachment #8345375 -
Flags: review?(mcote)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8345375 [details] [diff] [review]
devices.patch v1
Review of attachment 8345375 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good; just one comment.
::: autophone.py
@@ +402,5 @@
> + device_hash['all'] = 1
> + else:
> + for device in devices:
> + device_hash[device] = 1
> + tests.append((x[1], config, device_hash))
Why not use a set instead of a hash?
Attachment #8345375 -
Flags: review?(mcote) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Didn't even occur to me for some reason. I'll do that.
|
|
Assignee | |
Comment 3•12 years ago
|
||
This is what I checked in.
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•4 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•